- Notifications
You must be signed in to change notification settings - Fork1k
Feature(Surrealdb Core) - Allow ON DUPLICATE KEYS to update by record AND add update to rpc#5653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 tasks
…e-ON/DUPLICATE/KEY/UPDATE
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
vThank you for submitting this pull request. We really appreciate you spending the time to work on SurrealDB. 🚀 🎉
What is the motivation?
I wanted to insert multiple records, but if the key exists to update the existing record with a specific update for each insertion. I thought Upsert would a be suitable canidate, but Upsert weirdly mimics Update and it does not allow multiple record upsertions at once. I didnt want to rewrite the Upsert from ground up, so I decided just to adjust INSERT statement. So, I can define for each record I am inserting a compatible update (or not).
The implementation was heavily motivated for usage in sdks, have less request/ not having to use raw sql code, to archive big data Operations.
What does this change do?
It extends the capability of ON DUPLICATE KEY UPDATE.
@field =@value will still work and corresponds to: for all inserts this change will be implemneted if it already exists.
[{@field =@value, ... },...] can now also be used: each index of the array correponds to the index of the inserts
What is your testing strategy?
added tests
Is this related to any issues?
Does this change need documentation?
surrealdb/docs.surrealdb.com#1227
Have you read the Contributing Guidelines?
Yes, I have read theContributing Guidelines