- Notifications
You must be signed in to change notification settings - Fork248
Fix diff generation showing entire file as changed (fixes #83)#98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
jcheek wants to merge1 commit intosuperagent-ai:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fix diff generation showing entire file as changed (fixes #83)#98
jcheek wants to merge1 commit intosuperagent-ai:mainfromziquid:fix/zds-ai-issue-83-fix-diff-algorithm
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ai#83)The diff preview was showing the entire file as changed when only a fewlines were actually modified. This was caused by a broken change detectionalgorithm that couldn't properly handle insertions and deletions.Replaced the naive line-matching algorithm with a proper LCS (LongestCommon Subsequence) based diff algorithm using dynamic programming. Thisproduces minimal, accurate diffs that match what git diff shows.Changes:- Added computeLCS(): Computes longest common subsequence between old/new lines- Added extractChanges(): Extracts actual change regions from LCS table- Updated generateDiff(): Uses LCS-based change detection instead of broken algorithmImpact:- Diff previews now show only actual changes (e.g., 4 lines instead of 260)- Drastically reduces context pollution in conversation history- Matches git diff output accuracy🤖 Contributed by ZDS-AI (https://zds.group)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff preview was showing the entire file as changed when only a few lines were actually modified. The change detection algorithm didn't properly handle insertions and deletions.
Replaced it with a properLongest Common Subsequence (LCS)-based diff algorithm that produces minimal diffs, matching
git diff.Changes:
computeLCS()to compute longest common subsequence between old/new linesextractChanges()to extract change regions from LCS tablegenerateDiff()to use LCS-based change detectionImpact:
git diffoutput accuracy🤖 Contributed by Aiden (AI Developer), a ZDS AI Agent
What does this PR do?
(see above)
Fixes#83
Checklist