Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

www(chore): clarify image paths#41451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dnywh wants to merge10 commits intomaster
base:master
Choose a base branch
Loading
fromdnywh/chore/blog-image-frontmatter

Conversation

@dnywh
Copy link
Contributor

@dnywhdnywh commentedDec 18, 2025
edited
Loading

What kind of change does this PR introduce?

Frontmatter name change.

What is the current behavior?

We repeatedly mistakethumb forimage and visa versa, meaning the wrong images are used for Open Graph and in-site thumbnails on blog posts. Events and case studies use the same naming convention too.

What is the new behavior?

These two bits of frontmatter are renamed for clarity:

  • Blog posts:imgSite +imgSocial

That mapping for blog posts:

  • thumb is nowimgSite
  • image is nowimgSocial

These two remain the same:

  • Events:thumb
  • Case studies:imgSite

Thewww/README.md file has been expanded to clarify all of the above. It now also provides instructions on image optimisation.

To test

A lot of files were touched here. Please help make sure:

  • The CMS works as intended. This is thebiggest unknown.
  • All blog posts render the correct image as their on-site thumbnail and Open Graph image. You can test the latter by firing up a draft iMessage. Online Open Graph services like Facebook cache images, so aren’t reliable.
  • All events render their correct images.
  • All case studies render their correct images.

@vercel
Copy link

vercelbot commentedDec 18, 2025
edited
Loading

The latest updates on your projects. Learn more aboutVercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
zone-www-dot-comReadyReadyPreview,CommentDec 18, 2025 5:59am
7 Skipped Deployments
ProjectDeploymentReviewUpdated (UTC)
studioIgnoredIgnoredDec 18, 2025 5:59am
cmsSkippedSkippedDec 18, 2025 5:59am
design-systemSkippedSkippedDec 18, 2025 5:59am
docsSkippedSkippedDec 18, 2025 5:59am
studio-self-hostedSkippedSkippedDec 18, 2025 5:59am
studio-stagingSkippedSkippedDec 18, 2025 5:59am
ui-librarySkippedSkippedDec 18, 2025 5:59am

@coderabbitai
Copy link
Contributor

coderabbitaibot commentedDec 18, 2025
edited
Loading

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

192 files out of 299 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branchdnywh/chore/blog-image-frontmatter

Comment@coderabbitai help to get the list of available commands and usage tips.

@supabase
Copy link

This pull request has been ignored for the connected projectxguihxuzqibwxjnimxev because there are no changes detected insupabase directory. You can change this behaviour inProject Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more aboutSupabase Branching ↗︎.

@github-actionsgithub-actionsbot added the documentationImprovements or additions to documentation labelDec 18, 2025
@dnywhdnywh marked this pull request as ready for reviewDecember 18, 2025 05:47
@dnywhdnywh requested a review froma team as acode ownerDecember 18, 2025 05:47
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Duplicate of file fromwww. We seem to have a few of these. One for another time...

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please review this to make sure it works as intended!

@@ -44,7 +44,7 @@ export const data = {
height="14.72"
rx="1.92"
stroke="currentColor"
stroke-width="1.28"
strokeWidth="1.28"
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unrelated fix, sorry. Was just causing a Next error.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This and other image swap-outs are unrelated, sorry. Just saw some images that needed downsizing.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unrelated change for capitalisation. Sorry.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dnywh

[8]ページ先頭

©2009-2025 Movatter.jp