Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork139
feat: separate Node class into FileNode and DirNode classes#1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Copilot wants to merge2 commits intomasterChoose a base branch fromcopilot/fix-1181
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: streamich <9773803+streamich@users.noreply.github.com>
CopilotAI changed the title[WIP] Separatefeat: separate Node class into FileNode and DirNode classesSep 10, 2025
Node class for files and directoriesCopilot finished work on behalf ofstreamichSeptember 10, 2025 13:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR separates the monolithic
Nodeclass into specializedFileNodeandDirNodeclasses that inherit from a common abstractNodebase class, improving code organization and type safety.Changes Made
Nodebase class: Contains common functionality like timestamps, permissions, mode, uid/gid, symlink support, and permission checksFileNodeclass: ExtendsNodewith file-specific operations (getString(),setString(),getBuffer(),setBuffer(),write(),read(),truncate(), and thebufproperty)DirNodeclass: ExtendsNodefor directories (no buffer operations needed)Superblock.createNode()to instantiate the appropriate node type based on file mode (S_IFDIR→DirNode, otherwise →FileNode)FileNodeandDirNodeto module exports alongside the baseNodeclassBenefits
FileNodeNodeclassTesting
FileNode)The implementation maintains full backward compatibility while providing a cleaner, more maintainable codebase structure.
Fixes#1181.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Clickhere to start the survey.