- Notifications
You must be signed in to change notification settings - Fork190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
updating opencl multi_normal_cholesky_lpdf to match the other implementation#3021
Open
syclik wants to merge1 commit intodevelopChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I think we need an opencl version of check_cholesky_factor to have parity |
Yup! You're absolutely right. I'll get to it soon. …On Tue, Feb 6, 2024 at 11:01 AM Steve Bronder ***@***.***> wrote: I think we need an opencl version of check_cholesky_factor to have parity — Reply to this email directly, view it on GitHub <#3021 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADH6F4I6OEKVHTVGNBIJPTYSJHXFAVCNFSM6AAAAABC3FIIRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZQGEZDKNZVGI> . You are receiving this because you authored the thread.Message ID: ***@***.***> |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#3002 missed checking cholesky factor for the opencl version of multi_normal_cholesky_lpdf.
This PR adds in the
check_cholesky_factor. This should now pass the CI tests.Tests
No new tests. There is a current test in
developthat fails when running with opencl.Side Effects
None.
Release notes
Updating opencl multi_cholesky_normal_lpdf implementation to check that the input is a valid cholesky factor.
Checklist
Copyright holder: Daniel Lee
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested