- Notifications
You must be signed in to change notification settings - Fork474
Add docs link to provider pop up, add better GitHub docs#829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Changes from1 commit
484cb1ce75af8eb202a0ba732740a59c21fdcd06119aef96a358b181f0db6ee2048e5f9eda953689ffefa0e2c4ec0f52ad215b2fb2d0d0d2d60e2745e18276e540c93fc8790b35f0a7ba4de74a637b84b5089947f93ce8a707662918abd5f360fc0d6815c9d5652db5c1482af59e40551587ff97b4e49defa0e63c809c707e95c12d31158efacc2fc3378723ce5835c3480d467143cc287e4d53af79236cb8b4b2d3bb0f518a0851598c3c5a15365b6f8c18357b5f52246bcc5fbe3bdba4ac25f27a33b714e92a1b00d667c109e16744186a401bfa7258301a1ed32e5f670a815d7550521b284efbe8ee590231cca5ea293c292b32d603da0File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
…/auth-methods/providers.tsxCo-authored-by: Konsti Wohlwend <n2d4xc@gmail.com>
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -174,7 +174,7 @@ export function ProviderSettingDialog(props: Props & { open: boolean, onClose: ( | ||
| <Link | ||
| className={cn(buttonVariants({ variant: "outline", size: "sm" }), "gap-2 mt-2")} | ||
| href={`https://docs.stack-auth.com/docs/next/concepts/auth-providers/${props.id}`} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. The documentation URL construction will generate a broken link for the X/Twitter provider because the provider ID is "x" but the documentation file is named "x-twitter.mdx". View Details📝 Patch Detailsdiff --git a/apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/auth-methods/providers.tsx b/apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/auth-methods/providers.tsxindex fc756024..80faf844 100644--- a/apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/auth-methods/providers.tsx+++ b/apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/auth-methods/providers.tsx@@ -47,6 +47,12 @@ function toTitle(id: string) { }[id]; }+function toDocumentationSlug(id: string) {+ return {+ x: "x-twitter",+ }[id] || id;+}+ export const providerFormSchema = yupObject({ shared: yupBoolean().defined(), clientId: yupString()@@ -177,7 +183,7 @@ export function ProviderSettingDialog(props: Props & { open: boolean, onClose: ( <Link className={cn(buttonVariants({ variant: "outline", size: "sm" }), "gap-2 mt-2")}- href={`https://docs.stack-auth.com/docs/next/concepts/auth-providers/${props.id}`}+ href={`https://docs.stack-auth.com/docs/next/concepts/auth-providers/${toDocumentationSlug(props.id)}`} rel="noreferrer" > See full documentation AnalysisX/Twitter provider documentation URL generates 404 errorWhat fails: ProviderSettingDialog in How to reproduce:
Result: Redirects to Expected: Should navigate to | ||
| target="_blank" rel="noreferrer" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Bug: Security and Documentation Link IssuesThe new documentation link's | ||
| > | ||
| See full documentation | ||
| <ArrowRight size={16} /> | ||
Uh oh!
There was an error while loading.Please reload this page.