Commit1d15afd

committed

Fix longstanding error in VACUUM: sometimes would examine a buffer page

after writing/unpinning it. An actual failure is unlikely, unless thesystem is tremendously short of buffers ... but a bug is a bug.

1 parent807a262 commit1d15afdCopy full SHA for 1d15afd

File tree

-12

lines changed

-12

lines changed

Lines changed: 9 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/commands/vacuum.c,v 1.189 2001/03/25 23:23:58 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/vacuum.c,v 1.189.2.1 2001/06/29 16:34:49 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -577,7 +577,6 @@ scan_heap(VRelStats *vacrelstats, Relation onerel,`
`577`	`577`	`maxoff;`
`578`	`578`	`boolpgchanged,`
`579`	`579`	`tupgone,`
`580`		`-dobufrel,`
`581`	`580`	`notup;`
`582`	`581`	`char*relname;`
`583`	`582`	`VacPagevacpage,`
`@@ -876,15 +875,6 @@ scan_heap(VRelStats *vacrelstats, Relation onerel,`
`876`	`875`	`}`
`877`	`876`	`}`
`878`	`877`
`879`		`-if (pgchanged)`
`880`		`-{`
`881`		`-WriteBuffer(buf);`
`882`		`-dobufrel= false;`
`883`		`-changed_pages++;`
`884`		`-}`
`885`		`-else`
`886`		`-dobufrel= true;`
`887`		`-`
`888`	`878`	`if (tempPage!= (Page)NULL)`
`889`	`879`	`{/* Some tuples are gone */`
`890`	`880`	`PageRepairFragmentation(tempPage,NULL);`
`@@ -900,8 +890,15 @@ scan_heap(VRelStats *vacrelstats, Relation onerel,`
`900`	`890`	`free_size+=vacpage->free;`
`901`	`891`	`reap_page(vacuum_pages,vacpage);`
`902`	`892`	`}`
`903`		`-if (dobufrel)`
	`893`	`+`
	`894`	`+if (pgchanged)`
	`895`	`+{`
	`896`	`+WriteBuffer(buf);`
	`897`	`+changed_pages++;`
	`898`	`+}`
	`899`	`+else`
`904`	`900`	`ReleaseBuffer(buf);`
	`901`	`+`
`905`	`902`	`if (notup)`
`906`	`903`	`empty_end_pages++;`
`907`	`904`	`else`

Comments

(0)