Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add types forSqlite3Worker1Promiser#76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@sameoldlab
Copy link

No description provided.

@sameoldlab
Copy link
Author

sameoldlab commentedMay 28, 2024
edited
Loading

Progress:

  • Mostly done withSqlite3Worker1PromiserConfig. Not sure what goes in for the args ofgenerateMessageId
  • Need clearer documentation forPromiser Methodopen'sfilename andvfs
  • exec needs to add a full list of arguments, js eqivalent for sqlVALUE value used in row and bind
  • There is additional metadata returned byPromiser. Described as "// possibly other metadata ..." on sqlite docs. Not sure how stable these are / if they should be documented here.
  • Need to add type forPromiser response error stack trace array

As the methods are very similar to worker1, I'm hoping I can reduce what is specified here and reuse the existing types where possible.

@tomayac
Copy link
Collaborator

How does this relate to#54? Could you maybe join forces?

@sameoldlab
Copy link
Author

sameoldlab commentedMay 28, 2024
edited
Loading

How does this relate to#54? Could you maybe join forces?

Yes, It's for the same issue. I made my PR against thesqlite:types-improvement branch, so ideally that could get merged to main when everything is complete.

@sameoldlab
Copy link
Author

In that case would it make more sense for me to mark this as ready for review now and then track progress in#54?

@tomayac
Copy link
Collaborator

I think so, yes. Please ask someone from#54 for a review, and let's then merge it, so from thereon you can continue working on#54. Thanks!

sameoldlab reacted with thumbs up emoji

@sameoldlabsameoldlab marked this pull request as ready for reviewMay 28, 2024 07:56
@tomayactomayac merged commit14a23c0 intosqlite:types-improvementJun 3, 2024
@tomayac
Copy link
Collaborator

Merged, as whatever you have is better than the stub we had in#54. Let's continue the work on#54. Thank you!

sameoldlab and pubkey reacted with rocket emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sameoldlab@tomayac

[8]ページ先頭

©2009-2025 Movatter.jp