- Notifications
You must be signed in to change notification settings - Fork68
Add types forSqlite3Worker1Promiser#76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
sameoldlab commentedMay 28, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Progress:
As the methods are very similar to worker1, I'm hoping I can reduce what is specified here and reuse the existing types where possible. |
How does this relate to#54? Could you maybe join forces? |
sameoldlab commentedMay 28, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, It's for the same issue. I made my PR against thesqlite:types-improvement branch, so ideally that could get merged to main when everything is complete. |
In that case would it make more sense for me to mark this as ready for review now and then track progress in#54? |
No description provided.