- Notifications
You must be signed in to change notification settings - Fork68
Added forceReinitIfPreviouslyFailed to installOpfsSAHPoolVfs options#117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
FYIW, as the person who very reluctantly added the i strongly recommend leaving itout of any public interface. It's an ugly kludge for a buggy browser, not a solution to a real problem. |
First of all, thank you for implementing the fix (hack?)! 😄 The reason I've opened this PR is because I've encountered that same bug today. In my humble opinion, regardless whether this flag should exist, it seems there is currently still a need for it. The hope is of course that this will eventually get fixed on a browser-level, but until then, it may solve some users' problems (and save them some time by not having to dig through the whole#79 issue thread 😆). I hope this makes sense, but feel free to close the PR in case my reasoning doesn't convince you! |
Is there a browser bug you could nudge with the negative impact caused by this and a small reproduction case for the engineers to look at? I understand you're vague on purpose, but I think in this case at least linking from said bug report (which hopefully exists) to here would be an option. |
Here's the bug I raised a couple of hours ago to WebKit:https://bugs.webkit.org/show_bug.cgi?id=301520 (it seems to only be happening there, haven't been able to reproduce elsewhere). The issue appears very similar to the one described in#79. |
@karlcow This is aWebKit compat issue that currently affects users of SQLite Wasm. Any chance for someone from the team to take a look? Merci |
karlcow commentedOct 27, 2025
Thanks@tomayac and@jurerotar for the heads up. Let me check. |
Added forceReinitIfPreviouslyFailed to installOpfsSAHPoolVfs options, based on the discussion in#79