Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added forceReinitIfPreviouslyFailed to installOpfsSAHPoolVfs options#117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jurerotar wants to merge1 commit intosqlite:main
base:main
Choose a base branch
Loading
fromjurerotar:feat/forceReinitIfPreviouslyFailed

Conversation

@jurerotar
Copy link

Added forceReinitIfPreviouslyFailed to installOpfsSAHPoolVfs options, based on the discussion in#79

@sgbeal
Copy link
Collaborator

FYIW, as the person who very reluctantly added theforceReinitIfPreviouslyFailed flag (#79):DO NOT USE THAT FLAG. It's a workaround for one specific buggy browser and actively supporting buggy browsers is how the world got stuck with MSIE6 for so long.

i strongly recommend leaving itout of any public interface. It's an ugly kludge for a buggy browser, not a solution to a real problem.

@jurerotar
Copy link
Author

First of all, thank you for implementing the fix (hack?)! 😄

The reason I've opened this PR is because I've encountered that same bug today. In my humble opinion, regardless whether this flag should exist, it seems there is currently still a need for it. The hope is of course that this will eventually get fixed on a browser-level, but until then, it may solve some users' problems (and save them some time by not having to dig through the whole#79 issue thread 😆).

I hope this makes sense, but feel free to close the PR in case my reasoning doesn't convince you!

sgbeal reacted with thumbs up emoji

@tomayac
Copy link
Collaborator

Is there a browser bug you could nudge with the negative impact caused by this and a small reproduction case for the engineers to look at? I understand you're vague on purpose, but I think in this case at least linking from said bug report (which hopefully exists) to here would be an option.

@jurerotar
Copy link
Author

Here's the bug I raised a couple of hours ago to WebKit:https://bugs.webkit.org/show_bug.cgi?id=301520 (it seems to only be happening there, haven't been able to reproduce elsewhere).

The issue appears very similar to the one described in#79.

sgbeal reacted with thumbs up emoji

@tomayac
Copy link
Collaborator

@karlcow This is aWebKit compat issue that currently affects users of SQLite Wasm. Any chance for someone from the team to take a look? Merci:-)

sgbeal reacted with thumbs up emojijurerotar reacted with hooray emoji

@karlcow
Copy link

Thanks@tomayac and@jurerotar for the heads up. Let me check.

jurerotar and sgbeal reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jurerotar@sgbeal@tomayac@karlcow

[8]ページ先頭

©2009-2025 Movatter.jp