- Notifications
You must be signed in to change notification settings - Fork976
Fix MySQL Mathematical Expression Type Inference#4172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
rubensantoniorosa2704 wants to merge2 commits intosqlc-dev:mainChoose a base branch fromrubensantoniorosa2704:feat/mysql-expression-type-inference
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Fix MySQL Mathematical Expression Type Inference#4172
rubensantoniorosa2704 wants to merge2 commits intosqlc-dev:mainfromrubensantoniorosa2704:feat/mysql-expression-type-inference
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
a4b354e toef78ff2Compareef78ff2 to605cbc5Comparehts0000 commentedNov 26, 2025
Hello, may I ask when this PR will be merged? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This implements type inference for MySQL mathematical expressions. Before this change, queries with arithmetic operations would generate
interface{}types, which meant no compile-time type safety. Now the compiler properly infers types based on the operands and operators.Before:
After:
What changed
inferExprType()that recursively analyzes SQL expressions to determine their typesinterface{}/and%)Notes
The implementation is MySQL-specific for now. PostgreSQL and SQLite return
nilfromcombineGenericTypes()to maintain current behavior. There's a TODO comment about refactoringIsMathematicalOperator()to be engine-specific.Closes#4153