- Notifications
You must be signed in to change notification settings - Fork5.1k
Description
Hey! I can see that in order tocustomize shipping method handling, one have to define aSpree::ShipmentHandler::<constantized shipping method NAME>
class. Wouldn't that make sense to either use something else thanname
attribute in here (likeadmin_name
for example) or addpresentation
attribute to be used on the frontend?
I'm rising that as the current state of that enforces shop to use one-word and non-space-separated names of the shipping methods which seems a bit weird. Let's say you have a digital cards shipping method - in order to make that work, you have to use a single word name (DigitalCard orDigitalcard) which looks weird for the end user as it's gonna be displayed this way on the checkout. If we usedadmin_name
instead, we could not bother about what end users sees. However, i think addingpresentation
attribute seems more reasonable so neither admins nor customers are being presented with a weird shipping method names.
I'm also not sure about support for, say, polish letters in the class names. Which is another example of weirdness :)
If you think that should be changed, i'm happy to open a PR with that.