Commitc86e2a2

committed

Add tests to ensure passing a bogus role/filter won't be passed through to the API

1 parentb959129 commitc86e2a2Copy full SHA for c86e2a2

File tree

+33

-0

lines changed

+33

-0

lines changed

Lines changed: 22 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -284,6 +284,17 @@ def test_members_filters(self):`
`284`	`284`	`headers={}`
`285`	`285`	`)`
`286`	`286`
	`287`	`+deftest_members_excludes_fake_filters(self):`
	`288`	`+"""Show that one cannot pass a bogus filter to the API."""`
	`289`	`+i=self.instance.members(filter='bogus-filter')`
	`290`	`+self.get_next(i)`
	`291`	`+`
	`292`	`+self.session.get.assert_called_once_with(`
	`293`	`+url_for('members'),`
	`294`	`+params={'per_page':100},`
	`295`	`+headers={}`
	`296`	`+ )`
	`297`	`+`
`287`	`298`	`deftest_members_roles(self):`
`288`	`299`	`"""Show that one can iterate over all admins."""`
`289`	`300`	`i=self.instance.members(role='admin')`
`@@ -295,6 +306,17 @@ def test_members_roles(self):`
`295`	`306`	`headers={'Accept':'application/vnd.github.ironman-preview+json'}`
`296`	`307`	`)`
`297`	`308`
	`309`	`+deftest_members_excludes_fake_roles(self):`
	`310`	`+"""Show that one cannot pass a bogus role to the API."""`
	`311`	`+i=self.instance.members(role='bogus-role')`
	`312`	`+self.get_next(i)`
	`313`	`+`
	`314`	`+self.session.get.assert_called_once_with(`
	`315`	`+url_for('members'),`
	`316`	`+params={'per_page':100},`
	`317`	`+headers={}`
	`318`	`+ )`
	`319`	`+`
`298`	`320`	`deftest_public_members(self):`
`299`	`321`	`"""Show that one can iterate over all public members."""`
`300`	`322`	`i=self.instance.public_members()`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,17 @@ def test_members_roles(self):`
`168`	`168`	`headers={'Accept':'application/vnd.github.ironman-preview+json'}`
`169`	`169`	`)`
`170`	`170`
	`171`	`+deftest_members_excludes_fake_roles(self):`
	`172`	`+"""Show that one cannot pass a bogus role to the API."""`
	`173`	`+i=self.instance.members(role='bogus-role')`
	`174`	`+self.get_next(i)`
	`175`	`+`
	`176`	`+self.session.get.assert_called_once_with(`
	`177`	`+url_for('members'),`
	`178`	`+params={'per_page':100},`
	`179`	`+headers={}`
	`180`	`+ )`
	`181`	`+`
`171`	`182`	`deftest_members_requires_auth(self):`
`172`	`183`	`"""Show that one needs to authenticate to get team members."""`
`173`	`184`	`self.session.has_auth.return_value=False`

Comments

(0)