- Notifications
You must be signed in to change notification settings - Fork70
Remove deceptive unknown#55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mooncitydev left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was so much of a distraction for me that, wow, I've distracted myself further by making this PR.
The word, "unknown" in this message is at best unneeded and at worst deceptive. The error is almost certainly known. It was passed to the catch. We could figure it out. We could code to it. What we're doing is punting, because writing a bunch of error detecting code would be a distraction here. So, let's be honest about it. An error occurred. It is not unknown. We're simply punting it out.
This was so much of a distraction for me that, wow, I've distracted myself further by making this PR.
The word, "unknown" in this message is at best unneeded and at worst deceptive. The error is almost certainly known. It was passed to the catch. We could figure it out. We could code to it. What we're doing is punting, because writing a bunch of error detecting code would be a distraction here. So, let's be honest about it. An error occurred. It is not unknown. We're simply punting it out.