Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Redirection cookie handling tests for issue #2671#2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Zerkath wants to merge2 commits intosoftwaremill:master
base:master
Choose a base branch
Loading
fromZerkath:master

Conversation

@Zerkath
Copy link

Tests for#2671 which are now failing with the following output:

- should pass cookies during redirections *** FAILED *** (13 milliseconds)  Vector() did not contain element "session" (in Checkpoint) at FollowRedirectsBackendTest.scala:90  Vector() did not contain element "session" (in Checkpoint) at FollowRedirectsBackendTest.scala:90  Vector() did not contain element "session" (in Checkpoint) at FollowRedirectsBackendTest.scala:90  Vector() did not contain element "session" (in Checkpoint) at FollowRedirectsBackendTest.scala:90  Vector() did not contain element "session" (in Checkpoint) at FollowRedirectsBackendTest.scala:90  Vector(session=final) did not equal List(0-fuzz=, 1-fuzz=, 2-fuzz=, 3-fuzz=, 4-fuzz=, session=final) (in Checkpoint) at FollowRedirectsBackendTest.scala:118 (FollowRedirectsBackendTest.scala:119)

Before submitting pull request:

  • Check if the project compiles by runningsbt compile
  • Verify docs compilation by runningsbt compileDocs
  • Check if tests pass by runningsbt test
  • Format code by runningsbt scalafmt

Redirects do not apply set-cookie in the request chain meaningmultistep request chains that track state will be missing cookies in themiddle of redirection, only real alternative is manual controlAfter redirection chain completes any set-cookies that started or werein the middle of the request chain get ignored. Only the last responses set-cookie'swill be applied. It is possible to collect the cookies / headers fromresponse.history, but adds complexity.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Zerkath
[8]ページ先頭
©2009-2025 Movatter.jp