- Notifications
You must be signed in to change notification settings - Fork35
fix!: Throw error on invalid JSON in response#984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
jbelkins wants to merge4 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| lettraceInterceptor=TraceInterceptor<TestInput,TestOutput,HTTPRequest,HTTPResponse>(trace: trace) | ||
| letbuilder=OrchestratorBuilder<TestInput,TestOutput,HTTPRequest,HTTPResponse>() | ||
| .attributes(attributes) | ||
| .serialize({ input, builder, _in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The tests below used JSON fragments (i.e. a JSON string only) for serde since fragments were allowed and it kept the test setup simpler. Tests now serialize JSON objects.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description of changes
Currently, when a response contains invalid JSON, the error is caught & not rethrown, and the response body is treated as an empty JSON object
{}.This can lead to misleading responses, i.e. leading the caller to believe that the request succeeded but returned no results versus that it was not parseable.
guardthat handles the empty-response case now has some commentary to explain why it's there.NSErrorthat is thrown when JSON is invalid, and converting it to a successful response. That catch is now removed.{}. That behavior is unchanged.To be determined: figure out exactly what error should be thrown back to the caller, create it and throw it.
This is a breaking change in that it alters the SDK's behavior from "empty success" to throwing when unparseable data is encountered in a response.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.