- Notifications
You must be signed in to change notification settings - Fork1.2k
Optimize value_iterator::get_string()#2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CarlosEduR commentedJul 11, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@lemire I'd like to confirm it before making the PR ready for review I believe the current changes are not covering all cases we've talked about. In case the character
is it correct? |
| constchar* start = raw_json_string_result.value_unsafe().raw(); | ||
| constchar* json = start; | ||
| for (; *json !='\0'; ++json) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You don't think you need*json != '\0'... and, in fact, it is likely incorrect. The JSON spec does not forbig null characters inside the string as far as I can tell, and it does not enforce that the string be null terminated.
lemire commentedJul 11, 2024
Let me do some work of my own (next few hours). |
Relates to:#1470