- Notifications
You must be signed in to change notification settings - Fork744
[cp] Add test for cycle symlink#1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
| // Check last directory to exist is below maxdepth. | ||
| t.truthy(shell.test('-d',`${t.context.tmp}/copytestdepth${directory32deep}`)); | ||
| t.falsy(shell.test('-d',`${t.context.tmp}/copytestdepth${directory32deep}/32`)); | ||
| utils.skipOnWinForEPERM(shell.ln.bind(shell,'-s',`${t.context.tmp}/0`,`${t.context.tmp}/symlinktest`),()=>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Delete it because it doesn't create symlinks to check for cycle.
wafuwafu13 commentedSep 23, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
test passes in my local environment... 😓 |
Could you rebase? I recently updated CI to use GitHub actions instead. This may be more reliable than the old environment. |
codecov-commenter commentedFeb 1, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1045 +/- ##==========================================- Coverage 97.19% 97.04% -0.15%========================================== Files 36 36 Lines 1354 1354 ==========================================- Hits 1316 1314 -2- Misses 38 40 +2
Continue to review full report at Codecov.
|
I don't know how to solve this problem in windows, so close |
Thanks for trying the rebase. Looks like the error message fromhttps://github.com/shelljs/shelljs/runs/5018531671?check_suite_focus=true is: I wonder if |
|
Related:#739