- Notifications
You must be signed in to change notification settings - Fork1.8k
Add config to provide git push options#3159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… be used without [skip ci] commit message
…ng function argument to pushNotes
maximgubar commentedMay 17, 2024
@MatthewJohn since this PR is still in draft I assume you have some temporary solution atm? |
Hey@maximgubar, I'm afraid I really can't remember - I don't think it was working exactly as I wanted it to. I'll take a look to see if I can remember which project I was trying to use this for and if I did have a workaround. Prior to making this change, the main thing I did was to adjust the commit message format to no longer include '[skip ci]' (https://github.com/DockStudios/jmon/blob/main/.releaserc#L20) and then added rules in the Gitlab workflow to ignore commit messages that were release-like (https://github.com/DockStudios/jmon/blob/main/.gitlab-ci.yml#L57). I'll take a look to see if I can find evidence of a project using the changes in this PR to determine if they worked :D Matt |
I've created this change for myself (currently in testing) and created the PR to see if you believe it would be useful.
The rational behind this:
When I merge into Gitlab, semantic release runs on main and performs the release. The release commit, by default, uses
[skip ci], which is appropriate for Gitlab. Unfortunately, when the release commit is replicated to Github, italso respects this and skips Github actions.This change means that I change the commit message, removing [skip ci] and use a git push option
ci.skip(seehttps://docs.gitlab.com/ee/user/project/push_options.html), which will only skip the CI/CD pipeline in Gitlab.I'm creating this PR to get feedback if it's a feature that you believe would be useful and, if so, I can tidy it up after testing, add tests etc. ready for proper review :)
Many thanks
Matt