- Notifications
You must be signed in to change notification settings - Fork1.8k
feat: add --skip-remote-check option#2426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
thislooksfun wants to merge1 commit intosemantic-release:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This new option will bypass checking remote access. It only works in dryrun mode. This addressessemantic-release#2232.
Pinappleplayer approved these changesMay 2, 2022
codejedi365 commentedJan 7, 2023
Any movement on this? I would love to see this come to fruition. |
boxrick commentedApr 25, 2023
This would also help my current issue! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is a first draft of a new option to bypass checking remote access. It only works in dry run mode. There is still some work that needs to be done before it's ready to merge:
runthrow instead of returningfalse? (index.js#63)I took a first stab at writing some tests for this new flag, but I got lost in the tests and couldn't figure out how to make some of them work. If someone with more experience in this test suite could help out that would be greatly appreciated.
Once this is ready I will opened corresponding PRs on@semantic-release/github and@semantic-release/npm to use this option.
Closes#2232.