- Notifications
You must be signed in to change notification settings - Fork42
chore: upgrade filter#277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
scode2277 wants to merge6 commits intodevelopChoose a base branch fromchore/upgrade-filter
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+821 −344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
-take only tags from sidebar files-be able to open/close the sidebar sections-be consistence in terms of styling with vocs' components
vercelbot commentedOct 27, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for GitHub.
|
cloudflare-workers-and-pagesbot commentedOct 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Deploying frameworks with |
| Latest commit: | fe0dc7b |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://197499ac.frameworks-573.pages.dev |
| Branch Preview URL: | https://chore-upgrade-filter.frameworks-573.pages.dev |
I think it's better. I thought there was a performance issue, but it only happened once, and I could not reproduce it. Can you pull from development and resolve potential conflicts? |
… + add localStorage check
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading.Please reload this page.
Frameworks PR Checklist
Upgrade the filter to:
take only tags from sidebar files (no more tags from pages that are not live)
be able to open/close the sidebar sections (try it out ->https://chore-upgrade-filter.frameworks-573.pages.dev/intro/introduction/)
be consistent in terms of styling with vocs' components
Describe your changes, substitute this text with the information
If you are touching an existing piece of content, tag current contributors from the attribution list
If there is a steward for that framework, ask the steward to review it
If you're modifying the general outline, make sure to update it in the
vocs.config.tsadding thedev: trueparameterIf you need feedback for your content from the wider community, share the PR in our Discord
Review changes to ensure there are no typos, see instructions below