Commit242d85a

committed

fix(account): Update error message when asking for a contract that is not verified by etherscan

* BC break, major release* error is not 'NOTOK' anymore, ubt a conrete error message* still ways to improve

1 parent61a95c7 commit242d85aCopy full SHA for 242d85a

File tree

+16

-9

lines changed

+16

-9

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,11 @@ module.exports = function(chain, timeout) {`
`37`	`37`	`vardata=response.data;`
`38`	`38`
`39`	`39`	`if(data.status&&data.status!=1){`
`40`		`-returnreject(data.message);`
	`40`	`+letreturnMessage='NOTOK';`
	`41`	`+if(data.result&&typeofdata.result==='string'){`
	`42`	`+returnMessage=data.result;`
	`43`	`+}`
	`44`	`+returnreject(returnMessage);`
`41`	`45`	`}`
`42`	`46`
`43`	`47`	`if(data.error){`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,8 @@`
`33`	`33`	`},`
`34`	`34`	`"homepage":"https://github.com/sebs/etherscan-api#readme",`
`35`	`35`	`"devDependencies": {`
`36`		`-"browserify":"^16.2.2",`
`37`		`-"chai":"^4.0.2",`
	`36`	`+"browserify":"^16.2.3",`
	`37`	`+"chai":"^4.2.0",`
`38`	`38`	`"changelog":"^1.4.2",`
`39`	`39`	`"ink-docstrap":"^1.3.2",`
`40`	`40`	`"jsdoc":"^3.5.5",`
`@@ -44,7 +44,7 @@`
`44`	`44`	`},`
`45`	`45`	`"dependencies": {`
`46`	`46`	`"axios":"^0.18.0",`
`47`		`-"gh-pages":"^2.0.0",`
	`47`	`+"gh-pages":"^2.0.1",`
`48`	`48`	`"querystring":"^0.2.0"`
`49`	`49`	`}`
`50`	`50`	`}`

Lines changed: 8 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -144,12 +144,15 @@ describe('api', function() {`
`144`	`144`	`done();`
`145`	`145`	`});`
`146`	`146`	`});`
`147`		`-`
`148`		`-xit('contract.getabi',function(done){`
`149`		`-varapi=init();`
	`147`	`+// test for bug #31`
	`148`	`+// see https://github.com/sebs/etherscan-api/issues/31`
	`149`	`+it('contract.getabi for a contract that is not verified by etherscan: error',function(done){`
	`150`	`+varapi=init('test','ropsten',10000);`
`150`	`151`	`varabi=api.contract.getabi('0xBB9bc244D798123fDe783fCc1C72d3Bb8C189413');`
`151`		`-abi.then(function(res){`
`152`		`-assert.ok(res);`
	`152`	`+abi.then(function(){`
	`153`	`+assert.false(true,'should not be a success');`
	`154`	`+}).catch(err=>{`
	`155`	`+assert.equal(err,'Contract source code not verified');`
`153`	`156`	`done();`
`154`	`157`	`});`
`155`	`158`	`});`

Comments

(0)