Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
This repository was archived by the owner on Sep 7, 2023. It is now read-only.
/searxPublic archive

Add SpellChecker for requests#2777

Open
MykolaSauliak wants to merge2 commits intosearx:master
base:master
Choose a base branch
Loading
fromMykolaSauliak:master

Conversation

MykolaSauliak
Copy link

@MykolaSauliakMykolaSauliak commentedApr 23, 2021
edited
Loading

What does this PR do?

Add new visual block (in results template) with a hint for correct request sentence
results.html and webapp.py are changed

image

Why is this change important?

other search engines have such feature
good to have I guess

How to test this PR locally?

make run

Author's checklist

Related issues

@unixfox
Copy link
Member

unixfox commentedApr 24, 2021
edited
Loading

Did you test the behavior with the Google engine because if I remember well we already fetch the spellchecker of Google and show it as a suggestion?

@MykolaSauliak
Copy link
Author

MykolaSauliak commentedApr 24, 2021 via email

I'm using python library, didn't find any google spellchecker or it doesn'twork nowсб, 24 квіт. 2021, 09:32 користувач Émilien Devos ***@***.***>пише:
Did you test the behavior with the Google engine because if I remember well we already fetch the spellchecker of Google and show it as a suggestion. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2777 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEBEJTHLX7HNZKYPELROKKTTKJQYHANCNFSM43PNXMOA> .

@kvchkvch requested a review fromasciimooMay 2, 2021 17:56
@asciimoo
Copy link
Member

asciimoo commentedMay 3, 2021
edited
Loading

Ohi! Thanks for the contribution. It is a useful and highly requested feature, however the implementation has some flaws. First, it doesn't support properly multiple languages currently, second it introduces a new dependency, what we try to avoid if it isn't necessary. I'm thinking about implementing it as a stand-alone plugin. In this case the extra dependency wouldn't cause an issue for all of our admins, anyone can decide if they want to install it. What do you think? If you agree, you can find an example stand-alone plugin here:https://github.com/asciimoo/searx_external_plugin_example

@MykolaSauliak
Copy link
Author

MykolaSauliak commentedMay 3, 2021 via email

I didn't know about plugins for searxI can try to create a stand-alone plugin and then the community will decideto include or not this to the main codebaseDo you have any docs about plugins, how often they are used ?or if there are any ways to conduct a survey we can do that, it will giveus more information about this popularity of this featureпн, 3 трав. 2021 о 13:18 Adam Tauber ***@***.***> пише:
Ohi! Thanks for the contribution. It is a useful and highly requested feature, however the implementation has some flaws. First, it doesn't support multiple languages currently, second it introduces a new dependency, what we try to avoid if it isn't necessary. I'm thinking about implementing it as a stand-alone plugin. In this case the extra dependency wouldn't cause an issue for all of our admins, anyone can decide if they want to install it. What do you think? If you agree, you can find an example stand-alone plugin here:https://github.com/asciimoo/searx_external_plugin_example — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2777 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEBEJTFVYXQAVS66N7CKZYLTLZ2BFANCNFSM43PNXMOA> .

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@asciimooasciimooAwaiting requested review from asciimoo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@MykolaSauliak@unixfox@asciimoo

[8]ページ先頭

©2009-2025 Movatter.jp