This repository was archived by the owner on Sep 7, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork1.7k
Add SpellChecker for requests#2777
Open
MykolaSauliak wants to merge2 commits intosearx:masterChoose a base branch fromMykolaSauliak:master
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Did you test the behavior with the Google engine because if I remember well we already fetch the spellchecker of Google and show it as a suggestion? |
I'm using python library, didn't find any google spellchecker or it doesn'twork nowсб, 24 квіт. 2021, 09:32 користувач Émilien Devos ***@***.***>пише: … Did you test the behavior with the Google engine because if I remember well we already fetch the spellchecker of Google and show it as a suggestion. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2777 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEBEJTHLX7HNZKYPELROKKTTKJQYHANCNFSM43PNXMOA> . |
Ohi! Thanks for the contribution. It is a useful and highly requested feature, however the implementation has some flaws. First, it doesn't support properly multiple languages currently, second it introduces a new dependency, what we try to avoid if it isn't necessary. I'm thinking about implementing it as a stand-alone plugin. In this case the extra dependency wouldn't cause an issue for all of our admins, anyone can decide if they want to install it. What do you think? If you agree, you can find an example stand-alone plugin here:https://github.com/asciimoo/searx_external_plugin_example |
I didn't know about plugins for searxI can try to create a stand-alone plugin and then the community will decideto include or not this to the main codebaseDo you have any docs about plugins, how often they are used ?or if there are any ways to conduct a survey we can do that, it will giveus more information about this popularity of this featureпн, 3 трав. 2021 о 13:18 Adam Tauber ***@***.***> пише: … Ohi! Thanks for the contribution. It is a useful and highly requested feature, however the implementation has some flaws. First, it doesn't support multiple languages currently, second it introduces a new dependency, what we try to avoid if it isn't necessary. I'm thinking about implementing it as a stand-alone plugin. In this case the extra dependency wouldn't cause an issue for all of our admins, anyone can decide if they want to install it. What do you think? If you agree, you can find an example stand-alone plugin here:https://github.com/asciimoo/searx_external_plugin_example — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2777 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEBEJTFVYXQAVS66N7CKZYLTLZ2BFANCNFSM43PNXMOA> . |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new visual block (in results template) with a hint for correct request sentence
results.html and webapp.py are changed
Why is this change important?
other search engines have such feature
good to have I guess
How to test this PR locally?
make run
Author's checklist
Related issues