Current regex does not correctly capture valid ipv6 addresses, such as fd01::3:172:20:24:5 and thinks 127.0.0.0.0.0.1 is a valid address. This PR addresses these issues.

fix#4012

Description

Screenshot (if UI-related)

To-Dos

Successful buildyarn build
Translation keysyarn i18n:extract
Database migration (if required)

Issues Fixed or Closed

FixesIPv6 URLs not supported in Services #4012

fix(ipv6 regex matching): replaced existing regex for IPv4/6 address …

456885c

…matching with new oneCurrent regex does not correctly capture valid ipv6 addresses, such as fd01::3:172:20:24:5 andthinks 127.0.0.0.0.0.1 is a valid address. This PR addresses these issues.fixsct#4012

lmiklosko requested review fromsct,TheCatLady,danshilm andOwsleyJr ascode owners

March 4, 2025 09:02

Copy link

MilanJa commentedMar 7, 2025

Since they're being reused, you might as well extract those regex and put them into asrc/utils/validationHelpers.ts file that could be the single point for all complex regex and all the uses of it have descriptive names instead. But otherwise lgtm

Copy link

Owner

sct commentedMar 10, 2025

Since they're being reused, you might as well extract those regex and put them into asrc/utils/validationHelpers.ts file that could be the single point for all complex regex and all the uses of it have descriptive names instead. But otherwise lgtm

I think this is great feedback. Would you mind adopting this@lmiklosko?

fix: fix regex validation

a3d7259

fixsct#4012

Copy link

ContributorAuthor

lmiklosko commentedMar 12, 2025

Good idea@MilanJa. I've split those into separate regex IPv4/IPv6 and DNS, improving clarity. Might not be 100% accurate (eg. still matches 256.256.256.256 when combined with DNS matcher), but unlike before, allows all valid IPv6 addresses.