Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork630
refactor(api-v3): remove redundant call and arg inPed.PedGroup#1631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Accidentally pushed changes from other branch into here, I reverted them. |
Good catches, I was the one that created the flaws in116d61e. I wish I realized the second argument of
I had to use an inline code or a code block to reveal hidden HTML element tags, but it looks like you can't use all decorative HTML tags if there's any supported ones. Use the Markdown syntax. |
Ped.PedGroupc4491f2 intoscripthookvdotnet:mainUh oh!
There was an error while loading.Please reload this page.
Changed the title "refactor(api-v3): refactor Ped.PedGroup" because it doesn't say any of what the commit achieves other than refactoring Also enclosed the property name with backticks as usual since GitHub supports highlighting with inline codes in titles of commits, issues, and pull requests. alexguirre did this several times when committing toSollumz, and some people use this feature when committing toRust's codebase. |
Uh oh!
There was an error while loading.Please reload this page.
The previous implementation made two native calls:
IS_PED_IN_GROUP (via IsInGroup)
GET_PED_GROUP_INDEX
The first call is redundant because GET_PED_GROUP_INDEX already returns -1 when the is not in any group.
In addition, the second argument passed to GET_PED_GROUP_INDEX is unnecessary and has been removed.
Note by kagikn: The screenshot of the implementation code of
GET_PED_GROUP_INDEXis deleted as it exposed excessive part of code.