- Notifications
You must be signed in to change notification settings - Fork106
Implement a safe_url based on all standards#221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Gallaecio wants to merge36 commits intoscrapy:masterChoose a base branch fromGallaecio:safer-url
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Draft
Changes from1 commit
Commits
Show all changes
36 commits Select commitHold shift + click to select a range
4798aaf test_safe_url_idna: adjust test data to the test scope
Gallaecio86711dd Fix pytest-cov warning
Gallaecio030a996 Implement safe_url and provide partial test coverage
Gallaecio6f0dc16 Merge remote-tracking branch 'upstream/master' into safer-url
Gallaecio17ee8d6 Progress on typing
Gallaecioaef0532 Address typing issues
Gallaecioabe4032 Fix unicode encoding in userinfo and IPv6 parsing
Gallaecio86435df Progress on tests
Gallaecio79193bf Address issues reported by tests and static checkers
Gallaecio82f6e66 Complete test coverage for safe_url
Gallaecio81fc830 Progress on passing upstream tests
Gallaecio7e72474 Solve issues previously marked as expected failures
Gallaecio2c62859 Validate host parsing according to upstream URL living standard tests
Gallaecio3623c35 Cover port and path in upstream tests
Gallaecio2513ea1 Cover query and fragment in upstream tests
Gallaecio7d92740 Add upstream tests for domain_to_ascii
Gallaecio6a080da Add upstream tests for percent encoding
Gallaecio79eafeb Add a performance test
Gallaecio3028165 Add idna.txt to source distribution
Gallaecio091905e 2x speed-up at the cost of mishandling invalid code points
Gallaeciofea33a6 _percent_encode_after_encoding: 0.2 speed-up
Gallaecio184e5a7 0.1 speed-up
Gallaecio4c21a0e x1.2 speed up
Gallaecioc317f9e x1.67 speed up
Gallaecio7152d0b Remove unused code
Gallaecio9daca87 x1.125 speed up
Gallaecio88f32ae Use urllib.parse.unquote
Gallaecio63a2f2f Initial use of Cython (x7 speedup)
Gallaecioeefbb9e Use Cython for additional files (x1.5 speedup)
Gallaecio8185cdc Merge _encoding into _url and use uchar for state control
Gallaeciobd15eb9 Update test expectations
Gallaecio5b18c9a Merge remote-tracking branch 'scrapy/master' into safer-url
Gallaecio4960889 WIP
Gallaecio25ecb97 Refactor _URL
Gallaecio66b9154 Minor improvements
Gallaecio8f1f809 Minor change
GallaecioFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Validate host parsing according to upstream URL living standard tests
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit2c62859d53052f59299b6fb00dc966a08f455635
There are no files selected for viewing
15 changes: 8 additions & 7 deletionstests/test_url.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
11 changes: 6 additions & 5 deletionsw3lib/_url.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.