Nov 3, 2022 · Nov 4, 2022 · Nov 8, 2022 · Nov 8, 2022 · Nov 8, 2022 · Nov 9, 2022
diff --git a/tests/test_url.py b/tests/test_url.py


 @pytest.mark.parametrize(
    "input,base,failure,href,protocol,username,password,hostname,port,pathname",
    "input,base,failure,href,protocol,username,password,hostname,port,pathname,search,hash",
    (
        case
        if case[0] not in URL_TEST_DATA_KNOWN_ISSUES
                i.get("hostname"),
                i.get("port"),
                i.get("pathname"),
                i.get("search"),
                i.get("hash"),
            )
            for i in URL_TEST_DATA
            if not isinstance(i, str)
        )
    ),
 )
 def test_parse_url(
    input, base, failure, href, protocol, username, password, hostname, port, pathname
    input,
    base,
    failure,
    href,
    protocol,
    username,
    password,
    hostname,
    port,
    pathname,
    search,
    hash,
 ):
    if failure:
        with pytest.raises(ValueError):
    # TODO: Find out why we do not always get right whether path is supposed to
    # be / or an empty string.
    assert (_serialize_url_path(url) or "/") == (pathname or "/")
    # TODO: Cover additional fields
    # TODO: Find out why we do not always get right whether query is supposed
    # to be an empty string or None.
    assert (url.query or "") == (search[1:] if search else "")
    # TODO: Find out why we do not always get right whether fragment is
    # supposed to be an empty string or None.
    assert (url.fragment or "") == (hash[1:] if hash else "")
    # TODO: Address the TODOs above.
    # assert _serialize_url(url) == href
Original file line number	Diff line number	Diff line change
Expand Up		@@ -53,7 +53,7 @@


		@pytest.mark.parametrize(
		"input,base,failure,href,protocol,username,password,hostname,port,pathname",
		"input,base,failure,href,protocol,username,password,hostname,port,pathname,search,hash",
		(
		case
		if case[0] not in URL_TEST_DATA_KNOWN_ISSUES
Expand All		@@ -70,14 +70,27 @@
		i.get("hostname"),
		i.get("port"),
		i.get("pathname"),
		i.get("search"),
		i.get("hash"),
		)
		for i in URL_TEST_DATA
		if not isinstance(i, str)
		)
		),
		)
		def test_parse_url(
		input, base, failure, href, protocol, username, password, hostname, port, pathname
		input,
		base,
		failure,
		href,
		protocol,
		username,
		password,
		hostname,
		port,
		pathname,
		search,
		hash,
		):
		if failure:
		with pytest.raises(ValueError):
Expand All		@@ -93,7 +106,13 @@ def test_parse_url(
		# TODO: Find out why we do not always get right whether path is supposed to
		# be / or an empty string.
		assert (_serialize_url_path(url) or "/") == (pathname or "/")
		# TODO: Cover additional fields
		# TODO: Find out why we do not always get right whether query is supposed
		# to be an empty string or None.
		assert (url.query or "") == (search[1:] if search else "")
		# TODO: Find out why we do not always get right whether fragment is
		# supposed to be an empty string or None.
		assert (url.fragment or "") == (hash[1:] if hash else "")
		# TODO: Address the TODOs above.
		# assert _serialize_url(url) == href


Expand Down