- Notifications
You must be signed in to change notification settings - Fork106
Implement a safe_url based on all standards#221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I am having a hard time lowering the gap below the current one, which is 4-3 times slower than the previous implementation 😞 |
Looking atscrapy/scrapy#1306, maybe we could try going forhttps://chromium.googlesource.com/chromium/src/+/HEAD/url/ . |
Interesting read:https://daniel.haxx.se/blog/2022/01/10/dont-mix-url-parsers/ |
An interesting project:https://github.com/TkTech/can_ada |
Uh oh!
There was an error while loading.Please reload this page.
Continuation of#201.
Fixes#193.
Tasks:
The new implementation is currently around 3-4 times slower than the previous implementation for test cases where both have the same, non-error outcome.
test_parse_url.