- Notifications
You must be signed in to change notification settings - Fork2.7k
#350: Add Nox and basic pyproject.toml created by Poetry#353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
- Use new structure for code blocks in README
57c94dc tof251561CompareUh oh!
There was an error while loading.Please reload this page.
satwikkansal commentedOct 26, 2024
@nifadyev looks good, thanks, instead of merging into master, could you raise a PR against the dev branch please. We can merge in master when we've translated all the snippets to the new layout. |
nifadyev commentedOct 27, 2024
No problem,@satwikkansal. But in my opinion, it is more difficult to check and release huge PR than lots of small changes (so-calledTrunk based development). I remember how I made a translation, and it was a pain to check it before merging. |
satwikkansal commentedOct 29, 2024
I agree, think of |
nifadyev commentedOct 30, 2024
Agreed, I will start making small PRs into |
satwikkansal commentedOct 30, 2024
Great, feel free to create the issue, I'll put the label 👍 |
nifadyev commentedOct 31, 2024
Hey@satwikkansal , I don't have privileges to create new branches. Could you please create |
satwikkansal commentedNov 1, 2024
@nifadyev Done! |
nifadyev commentedNov 5, 2024
@satwikkansal , base branch has been changed to |
satwikkansal commentedNov 5, 2024
@nifadyev there's one merge conflict, could you resolve it please, I'll merge post that! |
nifadyev commentedNov 5, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@satwikkansal , thanks for noticing, the merge conflict has been resolved |
satwikkansal commentedNov 5, 2024
Yes, that's okay, I was wondering maybe we should increase the line length to 180, we can have separate linter for Python code and have line length set to a lower value there. |
af07227 intosatwikkansal:devUh oh!
There was an error while loading.Please reload this page.
nifadyev commentedNov 5, 2024
Sure, will be changed in next PRs |
Resolves#350
CC@satwikkansal