Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

#350: Add Nox and basic pyproject.toml created by Poetry#353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nifadyev
Copy link
Contributor

- Use new structure for code blocks in README
@satwikkansal
Copy link
Owner

@nifadyev looks good, thanks, instead of merging into master, could you raise a PR against the dev branch please. We can merge in master when we've translated all the snippets to the new layout.

@nifadyev
Copy link
ContributorAuthor

No problem,@satwikkansal. But in my opinion, it is more difficult to check and release huge PR than lots of small changes (so-calledTrunk based development). I remember how I made a translation, and it was a pain to check it before merging.

@satwikkansal
Copy link
Owner

But in my opinion, it is more difficult to check and release huge PR than lots of small changes (so-calledTrunk based development). I remember how I made a translation, and it was a pain to check it before merging.

I agree, think ofmaster branch as production code. Anddev branch for staging code. That doesn't mean we have to merge long PRs into thedev branch, we can still merge code incrementally in dev branch. And when we've tested the dev branch for consistency, then we can merge dev into master, that one will be a big PR, yes, but there won't be anything as such that hasn't been reviewed already carefully, so we should be good. Let me know your thoughts.

@nifadyev
Copy link
ContributorAuthor

Agreed, I will start making small PRs intodev branch. It would be awesome to create “parent” issue withgood first issue label and track the progress there. I hope the label will attract some contributors.

@satwikkansal
Copy link
Owner

Great, feel free to create the issue, I'll put the label 👍

@nifadyev
Copy link
ContributorAuthor

Hey@satwikkansal , I don't have privileges to create new branches. Could you please createdev and delete irrelevantdevelopment and3.0?

@satwikkansal
Copy link
Owner

@nifadyev Done!

@nifadyevnifadyev changed the base branch frommaster todevNovember 2, 2024 04:27
@nifadyev
Copy link
ContributorAuthor

@satwikkansal , base branch has been changed todev

@satwikkansal
Copy link
Owner

@nifadyev there's one merge conflict, could you resolve it please, I'll merge post that!

@nifadyev
Copy link
ContributorAuthor

nifadyev commentedNov 5, 2024
edited
Loading

@satwikkansal , thanks for noticing, the merge conflict has been resolved
Probably,markdownlint CI check should be optional for now sincemarkdown files are not fully fixed yet

@satwikkansal
Copy link
Owner

Yes, that's okay, I was wondering maybe we should increase the line length to 180, we can have separate linter for Python code and have line length set to a lower value there.

@satwikkansalsatwikkansal merged commitaf07227 intosatwikkansal:devNov 5, 2024
1 check failed
@nifadyev
Copy link
ContributorAuthor

we should increase the line length to 180, we can have separate linter for Python code

Sure, will be changed in next PRs

@nifadyevnifadyev deleted the #350/add-nox-support branchNovember 5, 2024 11:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@satwikkansalsatwikkansalsatwikkansal left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add nox with supported Python versions to test snippets

2 participants

@nifadyev@satwikkansal

[8]ページ先頭

©2009-2025 Movatter.jp