NotificationsYou must be signed in to change notification settings
Fork2.7k
Star36.8k

Add expample with unpack and subscr#198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

steffen19w23 wants to merge1 commit intosatwikkansal:master

base:master

Choose a base branch

fromsteffen19w23:master

Open

Add expample with unpack and subscr#198

steffen19w23 wants to merge1 commit intosatwikkansal:masterfromsteffen19w23:master

Conversation

Copy link

steffen19w23 commentedApr 22, 2020

No description provided.

Add expample with unpack and subscr

dd037e3

Copy link

Author

steffen19w23 commentedApr 22, 2020

see#197

satwikkansal added the new snippets label

Aug 8, 2020

Ngoc-mai123 approved these changes

Feb 29, 2024

View reviewed changes

Copy link

Contributor

nifadyev commentedOct 28, 2024

Hey@steffen19w23 , are you still interested in merging this PR into main? The explanation looks quite difficult to understand, mostly because of disassembled code. Few of users can read it. Could you make it more reader-friendly?

Copy link

Author

steffen19w23 commentedOct 28, 2024

Want to merge into main. Don't blame me that non-trivial behaviour can only explained in non-trivial manner.

Copy link

Contributor

nifadyev commentedOct 29, 2024

Sorry if my comment was offended to you, it wasn't meant to be.@satwikkansal also mentioned difficulties with understanding the snippet in issue'scomment.

So it is advised to try to simplify or rephrase the explanation a bit. If it is hard to do, we can suggest some changes in explanation.

Could you also check the snippet on relevant python versions (3.9 - 3.13)? The easiest way to do so is to checkout tothis branch, create a virtual environment, install dependencies and runnox. These changes are in review and not in main, butnox checks are necessary for new snippets