- Notifications
You must be signed in to change notification settings - Fork425
test(wtr): windows compat, kinda#5578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Don't delete SauceLabs tho(yet)
It's implicit in the files being in the test directory and long filenames cause problems on windows
easier to maintain and uncovered a few broken tests!
and everywhere
is SAUCE defined in CI?
This reverts commite4279e3.
| .catch((err)=>{ | ||
| console.error(err); | ||
| process.exit(1); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
was this removed b/c it's redundant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yep. Changing to a top-levelawait accomplishes the same thing.
39b40e4 intomasterUh oh!
There was an error while loading.Please reload this page.
Details
I did a lot of fiddling in#5548 to get integration tests to run on windows. I ended up abandoning that for our CI, but these changes are still good to have if we ever do want to explore that path.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item