Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update the Portal component to use the new react portal api (when overflowBoundaryElement is used for position)#3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bolivierjr wants to merge4 commits intosalesforce:master
base:master
Choose a base branch
Loading
frombolivierjr:update-to-react-portal

Conversation

@bolivierjr
Copy link
Contributor

Fixing Portal component by switching from ReactDOM.unstable_renderSubtreeIntoContainer to React.createPortal, so that the context from PortalSettings, carries through when having multiple layers of overflowBoundaryElement.

This would also get you one step closer to using react 18 in the future, since the ReactDOM unstable_renderSubtreeIntoContainer method will be deprecated and will need to change to the react portals api.

Fixes#3028

Additional description


CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • npm run lint:fix has been run and linting passes.
  • [] Mocha, Jest (Storyshots), andcomponents/component-docs.json CI tests pass (npm test).
  • Tests have been added for new props to prevent regressions in the future. Seereadme.
  • Review the appropriate Storybook stories. Openhttp://localhost:9001/.
  • Review tests are passing in the browser. Openhttp://localhost:8001/.
  • Review markup conforms toSLDS by looking atDOM snapshot strings.

REVIEWER checklist (do not remove)

  • CircleCI tests pass. This includes linting, Mocha, Jest, Storyshots, andcomponents/component-docs.json tests.
  • Tests have been added for new props to prevent regressions in the future. Seereadme.
  • Review the appropriate Storybook stories. Openhttp://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Openhttp://localhost:9001/.
  • Review tests are passing in the browser. Openhttp://localhost:8001/.
  • Review markup conforms toSLDS by looking atDOM snapshot strings.
Required only if there are markup / UX changes
  • Add year-first date and commit SHA tolast-slds-markup-review inpackage.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA,last-accessibility-review, topackage.json and push.
  • While the contributor's branch is checked out, runnpm run local-update within locally clonedsite repo to confirm the site will function correctly at the next release.

…ntainer to React.createPortal, so that the context from PortalSettings, carries through when having multiple layers.
…s when it's not a portalMount and using the actual react portals so it does not have breaking changes if someone is using these props.
…Container so the id, classNames and styles get into the portalNode before updating the state for portalContainer
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple layers of overflowBoundaryElement on popover/dropdown components does not work correctly

1 participant

@bolivierjr

[8]ページ先頭

©2009-2025 Movatter.jp