- Notifications
You must be signed in to change notification settings - Fork1.3k
Fix: Sanitize YouTube No-Cookie URL by Validating Hostname#1716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
apodacaduron wants to merge1 commit intosachinchoolur:masterChoose a base branch fromapodacaduron:fix/youtube-nocookie-host-check
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fix: Sanitize YouTube No-Cookie URL by Validating Hostname#1716
apodacaduron wants to merge1 commit intosachinchoolur:masterfromapodacaduron:fix/youtube-nocookie-host-check
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Replaces substring check in `isYouTubeNoCookie()` with explicit hostname validationusing the URL constructor. This prevents potential false positives or security risksfrom malformed or malicious URLs.Fix suggested by static analysis (CodeQL) and aligns with best practices forURL sanitization.
CLAassistant commentedJun 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of
isYouTubeNoCookie(url)uses a substring check:This is unsafe because
youtube-nocookie.comcan appear anywhere in the string, including in malicious or misleading URLs such as:https://attacker.com/youtube-nocookie.com.fake.siteThis would incorrectly pass the check, even though the host is not
youtube-nocookie.com.Solution
This PR improves the validation by parsing the URL with the URL constructor and comparing the host value directly:
This ensures the function only returns true for valid URLs that have an exact hostname match.
Benefits
✅ Prevents false positives on malicious or incorrectly formatted URLs
✅ Improves security by relying on structured URL parsing
✅ Passes CodeQL analysis and aligns with secure coding practices
✅ Makes the plugin more robust and reliable