Emit declaration files into the correct location based on WebPack's context#136

Open

bryanforbes wants to merge2 commits intos-panferov:master

base:master

Choose a base branch

frombryanforbes:declaration-emit

Open

Emit declaration files into the correct location based on WebPack's context#136

bryanforbes wants to merge2 commits intos-panferov:masterfrombryanforbes:declaration-emit

Conversation

Copy link

bryanforbes commentedMay 13, 2016

Given the following project structure:

project/    src/        thing1.ts        thing2.ts

and the following WebPack configuration:

module.exports={context:'src',entry:{thing1:'thing1.ts',thing2:'thing2.ts'},output:{path:path.join(__dirname,'dist'),filename:'[name].js',libraryTarget:'umd'},resolve:{extensions:['','.ts','.js'],root:'src'},module:{loaders:[{test:/\.ts$/,loader:'awesome-typescript-loader',query:{declaration:true}}]}};

The following directory structure is created:

project/    dist/        src/            thing1.d.ts            thing2.d.ts        thing1.js        thing2.js

This pull request updates the declaration file destination calculation to use WebPack'sloaderUtils to determine where to emit the declaration file. This pull request does not cover "elided" declaration files which will still output with the incorrect path.

bryanforbes added2 commits

May 13, 2016 17:32

Emit declaration files into the correct location based on WebPack's c…

a9a0ac8

…ontext

Add unit test for contextual declaration files

069f1b0

s-panferov added enhancement need more info labels

May 14, 2016

Copy link

Owner

s-panferov commentedMay 14, 2016

@bryanforbes thanks for the PR! I need to make some research to find the best way to store declaration files. I'll try not to prolong this.

17cupsofcoffee mentioned this pull request

May 27, 2016

Use a relative path for the declaration assetsTypeStrong/ts-loader#214

Merged

ghost mentioned this pull request

Sep 30, 2016

Declaration file sub-folder issue#193

Open

gonzofish added a commit to gonzofish/angular-librarian that referenced this pull request

Mar 1, 2017

Adding dist/src to *ignore files

b3edf85

There is [an outstanding awesome-typescript-loader issue](s-panferov/awesome-typescript-loader#193) and [an unmerged PR](s-panferov/awesome-typescript-loader#136) which talk to this issue.Seems that, for the .d.ts files, ATL doesn't understand the Webpack context properly when outputting files.