Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Changed html, css, js, md and text file icons#455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
leodev12345 wants to merge2 commits intoryanoasis:master
base:master
Choose a base branch
Loading
fromleodev12345:master

Conversation

@leodev12345
Copy link

@leodev12345leodev12345 commentedJul 30, 2023
edited
Loading

Requirements (please check off with 'x')

What does this Pull Request (PR) do?

I have changed:

  • html and htm icon from <> to html 5 icon
  • slim and haml icons from <> to their logos
  • css # icon to css3 icon
  • javascript JS icon to the javascript logo icon
  • less icon from # to less logo
  • mjs icon from JS to node.js icon
  • markdown icon from arrow pointing down to md logo
  • changed icons for .gitignore, .gitattributes and .gitconfig to git logo
  • added icon for .gitmodules (git logo)
  • default text icon from the paragraph of text to a text box icon, personally i think it looks more like a file icon for a text file

How should this be manually tested?

By installing my fork of vim-devicons into vim, you can see the icons in NERDtree and airline tabs

Any background context you can provide?

These icons are just my personal preference so I don't know if they will make it into official vim-devicons
I think html5 and css3 is used pretty much all the time now so I dont see the point of having the old icons
Sorry if I didn't do something right this is my first time ever writing a PR

Screenshots (if appropriate or helpful)

You can see the updated html, css, and js icons in the NERDtree in this screenshot:
Snimka zaslona 2023-07-26 134312 (2)
Example of new default text file icon:
Screenshot 2
Example of new md icon:
Snimka zaslona 2023-07-30 144559
Example of new git icon:
Snimka zaslona 2023-07-26 134312 (3)

@marslo
Copy link

marslo commentedJan 9, 2024
edited
Loading

can you please help also enablegitcommit for.git/COMMIT_EDITMSG as well ?
i.e.:

$ git commit --amend

---- edit ----
Okay, never mind, I've added the gitcommit into#459
please let me know if you have any concern on this.

marslo added a commit to marslo/vim-devicons that referenced this pull requestJan 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leodev12345@marslo

[8]ページ先頭

©2009-2025 Movatter.jp