- Notifications
You must be signed in to change notification settings - Fork271
Allow custom distro icon#446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
fourpastmidnight wants to merge3 commits intoryanoasis:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Allow custom distro icon#446
fourpastmidnight wants to merge3 commits intoryanoasis:masterfromfourpastmidnight:allow-custo-distro-icon
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Create a new configuration option to allow one to specify they own distro icon.
HoneyBearCodes commentedOct 8, 2024
I previously used the Material Icon plugin in VSCode, and I loved how it not only provided file icons but also customized folder icons based on their types—like styles, tests, utils, views, and models. I think this feature really enhances organization and visibility. How can I submit a feature request to implement something similar? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Requirements (please check off with 'x')
What does this Pull Request (PR) do?
Adds a configuration variable,
g:WebDevIconsDistroto allow users to specify their distribution's icon. Several popular distributions are not supported "out of the box" by this plugin, i.e., Fedora, Suse Linux, etc. This PR also adds my particular distro: Manjaro Linux.How should this be manually tested?
I use vim-plug as my vim plugin manager. I have vim-devicons plugin listed last, as directed.
I use
let g:WebDevIconsDistro = "\uF30B"in my.vimrcto force vim-devicons to use my selected icon. This produced the following result:Next, I removed the custom distro icon setting from my
.vimrcto test that the addition of Manjaro as a detected Linux distribution is working. This resulted in:Any background context you can provide?
N/A
What are the relevant tickets (if any)?
Fixes#445
Screenshots (if appropriate or helpful)
N/A