inline_block_paren_depth is initialized asnil.
But the codeinline_block_paren_depth += 1,inline_block_paren_depth -= 1,inline_block_paren_depth == 0 has a possibility to raise unintendedNoMethodError.
It looks good to initializeinline_block_paren_depth is initialized as0 or add checks before the codes.

string_delimiter can benil as a possibility. Adding checks looks better.

Make the code in scanner/groovy.rb robust.

950c2f6

korny self-assigned this

Feb 23, 2019

korny added the Scanners label

Feb 23, 2019

Copy link

ContributorAuthor

junaruga commentedFeb 23, 2019•
edited
Loading

This report is by a static code analysis tool in our company (Maybe Coverity Scan).

Copy link

Member

korny commentedFeb 23, 2019

Mmh. I don’t think there’s really a bug here, since I never got an error with the current version even with thorough testing (see the scanner test suite). While I agree with the first change, the second one would slow down the scanner. I don’t think we need such checks unless someone can actually produce an error here :)

Copy link

ContributorAuthor

junaruga commentedFeb 24, 2019

Sure,@korny . I respect your decision. It's up to you.

Labels

Scanners

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make the code in scanner/groovy.rb robust.#228

Are you sure you want to change the base?

Make the code in scanner/groovy.rb robust.#228

Uh oh!