- Notifications
You must be signed in to change notification settings - Fork5.5k
Singleton classes of unshareable objects are not shareable#15656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
etiennebarrie wants to merge1 commit intoruby:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+20 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
etiennebarrie commentedDec 19, 2025
This test forking while Ractors are running fails:8bf333a |
b491568 toda98b05CompareContributorAuthor
etiennebarrie commentedDec 19, 2025
The test added in8bf333a fails here as well. |
Currently, all RClasses are created as shareable in `class_alloc0`,which causes singleton classes of unshareable objects to be shareablewhich allows passing unshareable objects by passing their singletonclass and getting their attached object.This changes `singleton_class_of` to mark the singleton class as shareablewhen the object is shareable, and inversely, to mark the singleton class asunshareable if the object is unshareable.We also need to not forcibly mark the class as shareable in`shareable_p_enter`.Additionally, if the object is not yet marked as shareable, but isfrozen (and `allow_frozen_shareable_p`), it becomes marked as shareablethrough `rb_ractor_shareable_p`, and we need to also mark its singletonclass as shareable at that point.
da98b05 to2e8459eComparelaunchable-appbot commentedDec 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
❌11/66414 Tests Failedbootstraptest/test_insns.rb#bootstraptest/test_insns.rbbootstraptest/test_jump.rb#bootstraptest/test_jump.rb 🛡️ never-failing, but failed nowbootstraptest/test_literal_suffix.rb#bootstraptest/test_literal_suffix.rb 🛡️ never-failing, but failed nowbootstraptest/test_method.rb#bootstraptest/test_method.rb 🛡️ never-failing, but failed nowbootstraptest/test_ractor.rb#bootstraptest/test_ractor.rb6 more failed testsbootstraptest/test_struct.rb#bootstraptest/test_struct.rbbootstraptest/test_syntax.rb#bootstraptest/test_syntax.rb 🛡️ never-failing, but failed nowbootstraptest/test_thread.rb#bootstraptest/test_thread.rbbootstraptest/test_yjit.rb#bootstraptest/test_yjit.rb 🛡️ never-failing, but failed nowtest/fiber/test_scheduler.rb#test_iseq_compile_under_gc_stress_bug_21180 🛡️ never-failing, but failed nowtest/ruby/test_alias.rb#test_alias_wb_miss |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, all RClasses are created as shareable in
class_alloc0, which causes singleton classes of unshareable objects to be shareable which allows passing unshareable objects by passing their singleton class and getting their attached object.This changes
singleton_class_ofto mark the singleton class as shareable when the object is shareable, and inversely, to mark the singleton class as unshareable if the object is unshareable.We also need to not forcibly mark the class as shareable in
shareable_p_enter.Additionally, if the object is not yet marked as shareable, but is frozen (and
allow_frozen_shareable_p), it becomes marked as shareable throughrb_ractor_shareable_p, and we need to also mark its singleton class as shareable at that point.