NotificationsYou must be signed in to change notification settings
Fork5.4k
Star22.5k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Update child module name when parent gets a temp name set#12658

Open

eileencodes wants to merge1 commit intoruby:master

base:master

Choose a base branch

fromeileencodes:fix-21094

Open

Update child module name when parent gets a temp name set#12658

eileencodes wants to merge1 commit intoruby:masterfromeileencodes:fix-21094

Conversation

Copy link

Member

eileencodes commentedJan 28, 2025•
edited
Loading

When callingset_temporary_name on a parent module the child modules should get their name updated too.

Before:

m=Module.newm::N=Module.newpm::N.name# => "#<Module:0x000000010d0a00b0>::N"m.set_temporary_name("foo")pm::N.name# => "#<Module:0x000000010d0a00b0>::N"

After:

m=Module.newm::N=Module.newpm::N.name# => "#<Module:0x000000010d0a00b0>::N"m.set_temporary_name("foo")pm::N.name# => "foo::N"

[Bug #21094]

Update child module name when parent gets a temp name set

51c103e

When calling `set_temporary_name` on a parent module the child modulesshould get their name updated too.Before:```rubym = Module.newm::N = Module.newp m::N.name # => "#<Module:0x000000010d0a00b0>::N"m.set_temporary_name("foo")p m::N.name # => "#<Module:0x000000010d0a00b0>::N"```After:```rubym = Module.newm::N = Module.newp m::N.name # => "#<Module:0x000000010d0a00b0>::N"m.set_temporary_name("foo")p m::N.name # => "foo::N"```[Bug #21094]

tenderlove approved these changes

Jan 28, 2025

View reviewed changes

Copy link

Member

nobu commentedJan 29, 2025

Shouldn’t this change too?

m=Module.newm::N=Module.newm::N::O=Module.newm.set_temporary_name("foo")pm::N::O

Copy link

MemberAuthor

eileencodes commentedJan 29, 2025

Ah yea that should work too. I'll fix it tomorrow morning.

nobu reviewed

Jan 29, 2025

View reviewed changes

variable.c

		VALUE value = ce->value;
		VALUE parental_path = ((VALUE ) payload);

		rb_mod_set_temporary_name(value, build_const_path(parental_path, id));

Copy link

Member

nobuJan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If the anonymous module has a constant that is not anonymous class or module, this will raise an exception.
And will crash on a non-class/module constant.