Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitee5e584

Browse files
jwrdegoedebentiss
authored andcommitted
HID: logitech-dj: Handle quad/bluetooth keyboards with a builtin trackpad
Some quad/bluetooth keyboards, such as the Dinovo Edge (Y-RAY81) have abuiltin touchpad. In this case when asking the receiver for paired devices,we get only 1 paired device with a device_type of REPORT_TYPE_KEYBOARD.This means that we do not instantiate a second dj_hiddev for the mouse(as we normally would) and thus there is no place for us to forward themouse input reports to, causing the touchpad part of the keyboard to notwork.There is no way for us to detect these keyboards, so this commit addsan array with device-ids for such keyboards and when a keyboard is onthis list it adds STD_MOUSE to the reports_supported bitmap for thedj_hiddev created for the keyboard fixing the touchpad not working.Using a list of device-ids for this is not ideal, but there are onlyvery few such keyboards so this should be fine. Besides the Dinovo Edge,other known wireless Logitech keyboards with a builtin touchpad are:* Dinovo Mini (TODO add its device-id to the list)* K400 (uses a unifying receiver so is not affected)* K600 (uses a unifying receiver so is not affected)Cc: stable@vger.kernel.orgBugLink:https://bugzilla.redhat.com/show_bug.cgi?id=1811424Fixes:f2113c3 ("HID: logitech-dj: add support for Logitech Bluetooth Mini-Receiver")Signed-off-by: Hans de Goede <hdegoede@redhat.com>Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
1 parentf59ee39 commitee5e584

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

‎drivers/hid/hid-logitech-dj.c‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -866,11 +866,23 @@ static void logi_dj_recv_queue_notification(struct dj_receiver_dev *djrcv_dev,
866866
schedule_work(&djrcv_dev->work);
867867
}
868868

869+
/*
870+
* Some quad/bluetooth keyboards have a builtin touchpad in this case we see
871+
* only 1 paired device with a device_type of REPORT_TYPE_KEYBOARD. For the
872+
* touchpad to work we must also forward mouse input reports to the dj_hiddev
873+
* created for the keyboard (instead of forwarding them to a second paired
874+
* device with a device_type of REPORT_TYPE_MOUSE as we normally would).
875+
*/
876+
staticconstu16kbd_builtin_touchpad_ids[]= {
877+
0xb309,/* Dinovo Edge */
878+
};
879+
869880
staticvoidlogi_hidpp_dev_conn_notif_equad(structhid_device*hdev,
870881
structhidpp_event*hidpp_report,
871882
structdj_workitem*workitem)
872883
{
873884
structdj_receiver_dev*djrcv_dev=hid_get_drvdata(hdev);
885+
inti,id;
874886

875887
workitem->type=WORKITEM_TYPE_PAIRED;
876888
workitem->device_type=hidpp_report->params[HIDPP_PARAM_DEVICE_INFO]&
@@ -882,6 +894,13 @@ static void logi_hidpp_dev_conn_notif_equad(struct hid_device *hdev,
882894
workitem->reports_supported |=STD_KEYBOARD |MULTIMEDIA |
883895
POWER_KEYS |MEDIA_CENTER |
884896
HIDPP;
897+
id= (workitem->quad_id_msb <<8) |workitem->quad_id_lsb;
898+
for (i=0;i<ARRAY_SIZE(kbd_builtin_touchpad_ids);i++) {
899+
if (id==kbd_builtin_touchpad_ids[i]) {
900+
workitem->reports_supported |=STD_MOUSE;
901+
break;
902+
}
903+
}
885904
break;
886905
caseREPORT_TYPE_MOUSE:
887906
workitem->reports_supported |=STD_MOUSE |HIDPP;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp