Commit986b9ea

Villemoes

authored and

torvalds

committed

kernel/sys.c: fix prototype of prctl_get_tid_address()

tid_addr is not a "pointer to (pointer to int in userspace)"; it is infact a "pointer to (pointer to int in userspace) in userspace". Sosparse rightfully complains about passing a kernel pointer toput_user().Reported-by: kernel test robot <lkp@intel.com>Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 parent23224e4 commit986b9eaCopy full SHA for 986b9ea

File tree

1 file changed

-3

lines changed

kernel
- sys.c

1 file changed

-3

lines changed

`‎kernel/sys.c‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2238,12 +2238,12 @@ static int prctl_set_mm(int opt, unsigned long addr,`
`2238`	`2238`	`}`
`2239`	`2239`
`2240`	`2240`	`#ifdefCONFIG_CHECKPOINT_RESTORE`
`2241`		`-staticintprctl_get_tid_address(structtask_structme,int__user*tid_addr)`
	`2241`	`+staticintprctl_get_tid_address(structtask_structme,int__user__user*tid_addr)`
`2242`	`2242`	`{`
`2243`	`2243`	`returnput_user(me->clear_child_tid,tid_addr);`
`2244`	`2244`	`}`
`2245`	`2245`	`#else`
`2246`		`-staticintprctl_get_tid_address(structtask_structme,int__user*tid_addr)`
	`2246`	`+staticintprctl_get_tid_address(structtask_structme,int__user__user*tid_addr)`
`2247`	`2247`	`{`
`2248`	`2248`	`return-EINVAL;`
`2249`	`2249`	`}`
`@@ -2427,7 +2427,7 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3,`
`2427`	`2427`	`error=prctl_set_mm(arg2,arg3,arg4,arg5);`
`2428`	`2428`	`break;`
`2429`	`2429`	`casePR_GET_TID_ADDRESS:`
`2430`		`-error=prctl_get_tid_address(me, (int__user**)arg2);`
	`2430`	`+error=prctl_get_tid_address(me, (int__user__user)arg2);`
`2431`	`2431`	`break;`
`2432`	`2432`	`casePR_SET_CHILD_SUBREAPER:`
`2433`	`2433`	`me->signal->is_child_subreaper= !!arg2;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit986b9ea

File tree

1 file changed

1 file changed

`‎kernel/sys.c‎`

0 commit comments