Commit8e1ac42

Quentin Perret

authored and

Peter Zijlstra

committed

sched/fair: Fix overutilized update in enqueue_task_fair()

enqueue_task_fair() attempts to skip the overutilized update for newtasks as their util_avg is not accurate yet. However, the flag we checkto do so is overwritten earlier on in the function, which makes thecondition pretty much a nop.Fix this by saving the flag early on.Fixes:2802bf3 ("sched/fair: Add over-utilization/tipping point indicator")Reported-by: Rick Yiu <rickyiu@google.com>Signed-off-by: Quentin Perret <qperret@google.com>Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>Link:https://lkml.kernel.org/r/20201112111201.2081902-1-qperret@google.com

1 parent8d4d9c7 commit8e1ac42Copy full SHA for 8e1ac42

File tree

1 file changed

-1

lines changed

kernel/sched
- fair.c

1 file changed

-1

lines changed

`‎kernel/sched/fair.c‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5477,6 +5477,7 @@ enqueue_task_fair(struct rq rq, struct task_struct p, int flags)`
`5477`	`5477`	`structcfs_rq*cfs_rq;`
`5478`	`5478`	`structsched_entity*se=&p->se;`
`5479`	`5479`	`intidle_h_nr_running=task_has_idle_policy(p);`
	`5480`	`+inttask_new= !(flags&ENQUEUE_WAKEUP);`
`5480`	`5481`
`5481`	`5482`	`/*`
`5482`	`5483`	`* The code below (indirectly) updates schedutil which looks at`
`@@ -5549,7 +5550,7 @@ enqueue_task_fair(struct rq rq, struct task_struct p, int flags)`
`5549`	`5550`	`* into account, but that is not straightforward to implement,`
`5550`	`5551`	`* and the following generally works well enough in practice.`
`5551`	`5552`	`*/`
`5552`		`-if (flags&ENQUEUE_WAKEUP)`
	`5553`	`+if (!task_new)`
`5553`	`5554`	`update_overutilized_status(rq);`
`5554`	`5555`
`5555`	`5556`	`enqueue_throttle:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8e1ac42

File tree

1 file changed

1 file changed

`‎kernel/sched/fair.c‎`

0 commit comments