NotificationsYou must be signed in to change notification settings
Fork0
Star2

Commit620cf45

Marc Zyngier

committed

KVM: arm64: Remove S1PTW check from kvm_vcpu_dabt_iswrite()

Now that kvm_vcpu_trap_is_write_fault() checks for S1PTW, thereis no need for kvm_vcpu_dabt_iswrite() to do the same thing, aswe already check for this condition on all existing paths.Drop the check and add a comment instead.Signed-off-by: Marc Zyngier <maz@kernel.org>Reviewed-by: Will Deacon <will@kernel.org>Link:https://lore.kernel.org/r/20200915104218.1284701-3-maz@kernel.org

1 parentc4ad98e commit620cf45Copy full SHA for 620cf45

File tree

1 file changed

-2

lines changed

arch/arm64/include/asm
- kvm_emulate.h

1 file changed

-2

lines changed

`‎arch/arm64/include/asm/kvm_emulate.h‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -303,10 +303,10 @@ static __always_inline bool kvm_vcpu_abt_iss1tw(const struct kvm_vcpu *vcpu)`
`303`	`303`	`return !!(kvm_vcpu_get_esr(vcpu)&ESR_ELx_S1PTW);`
`304`	`304`	`}`
`305`	`305`
	`306`	`+/* Always check for S1PTW before using this. */`
`306`	`307`	`static__always_inlineboolkvm_vcpu_dabt_iswrite(conststructkvm_vcpu*vcpu)`
`307`	`308`	`{`
`308`		`-return !!(kvm_vcpu_get_esr(vcpu)&ESR_ELx_WNR)\|\|`
`309`		`-kvm_vcpu_abt_iss1tw(vcpu);/* AF/DBM update */`
	`309`	`+returnkvm_vcpu_get_esr(vcpu)&ESR_ELx_WNR;`
`310`	`310`	`}`
`311`	`311`
`312`	`312`	`staticinlineboolkvm_vcpu_dabt_is_cm(conststructkvm_vcpu*vcpu)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit620cf45

File tree

1 file changed

1 file changed

`‎arch/arm64/include/asm/kvm_emulate.h‎`

0 commit comments