Commit294a7f1

iha

authored and

shuahkh

committed

lib: kunit: Fix compilation test when using TEST_BIT_FIELD_COMPILE

A build condition was missing around a compilation test, this compilationtest comes from the original test_bitfield code.And removed unnecessary code for this test.Fixes:d2585f5 ("lib: kunit: add bitfield test conversion to KUnit")Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>Link:https://lore.kernel.org/linux-next/20201015163056.56fcc835@canb.auug.org.au/Reviewed-by: Brendan Higgins <brendanhiggins@google.com>Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

1 parentd2585f5 commit294a7f1Copy full SHA for 294a7f1

File tree

1 file changed

-4

lines changed

lib
- bitfield_kunit.c

1 file changed

-4

lines changed

`‎lib/bitfield_kunit.c‎`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ static void __init test_bitfields_variables(struct kunit *context)`
`125`	`125`	`CHECK(u64,0x0000001f8000000ull);`
`126`	`126`	`}`
`127`	`127`
`128`		`-`
	`128`	`+#ifdefTEST_BITFIELD_COMPILE`
`129`	`129`	`staticvoid__inittest_bitfields_compile(structkunit*context)`
`130`	`130`	`{`
`131`	`131`	`/* these should fail compilation */`
`@@ -135,13 +135,11 @@ static void __init test_bitfields_compile(struct kunit *context)`
`135`	`135`	`/* this should at least give a warning */`
`136`	`136`	`u16_encode_bits(0,0x60000);`
`137`	`137`	`}`
	`138`	`+#endif`
`138`	`139`
`139`	`140`	`staticstructkunit_case__refdatabitfields_test_cases[]= {`
`140`	`141`	`KUNIT_CASE(test_bitfields_constants),`
`141`	`142`	`KUNIT_CASE(test_bitfields_variables),`
`142`		`-#ifdefTEST_BITFIELD_COMPILE`
`143`		`-KUNIT_CASE(test_bitfields_compile),`
`144`		`-#endif`
`145`	`143`	`{}`
`146`	`144`	`};`
`147`	`145`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit294a7f1

File tree

1 file changed

1 file changed

`‎lib/bitfield_kunit.c‎`

0 commit comments