NotificationsYou must be signed in to change notification settings
Fork229
Star2k

rtic-sync: No need for c-s to check if link is in wait queue if link is popped#1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

datdenkikniet merged 3 commits intomasterfromno-need-for-cs-if-popped

Mar 23, 2025

Merged

rtic-sync: No need for c-s to check if link is in wait queue if link is popped#1042

datdenkikniet merged 3 commits intomasterfromno-need-for-cs-if-popped

Mar 23, 2025

Conversation

Copy link

Contributor

datdenkikniet commentedMar 18, 2025•
edited
Loading

Minor improvement: if we insert our link into the wait queue, we always take a critical section (in theOnDrop) to ensure that it is no longer in the list on drop.

However, if our link is popped, we know for a fact that it is not in the list.take()-ing it in the block that gets us into that state saves us an unnecessary critical section, which is probably the 2nd-most common scenario (the 1st being finding a free slot immediately).

Additionally, we take a critical-section to check whether we still have an entry in ourSlotPtr. However, once we are certain that ourlink is removed from the list, we have exclusive access to it again: hence, we can skip that critical section too, on the happy path.

datdenkikniet force-pushed theno-need-for-cs-if-popped branch from09d7152 to53fab48Compare

March 18, 2025 21:28

datdenkikniet changed the title~~rtic-sync: No need for cs if wait-queue link is popped~~rtic-sync: No need for c-s to check if link is in wait queue if link is popped

Mar 18, 2025

datdenkikniet force-pushed theno-need-for-cs-if-popped branch 3 times, most recently fromd41a189 tof612ba0Compare

March 19, 2025 20:47