Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

starting to add jors#397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
gpilgrim2670 wants to merge12 commits intorstudio:main
base:main
Choose a base branch
Loading
fromgpilgrim2670:master
Draft

Conversation

@gpilgrim2670
Copy link

@gpilgrim2670gpilgrim2670 commentedMay 4, 2021
edited
Loading

I'm working on building a template for theJournal of Open Research Software.

To contribute a new article template to this package, please make sure you have done the following things (note thatjournalname_article below is only an example name):

  • This project uses a Contributor Licence Agreement (CLA) that you'll be asked to sign when opening a PR. This is required for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). We use a tool called CLA assistant for that.
    You could also, unless you have done it in any other RStudio's projects before, sign theindividual orcorporate contributor agreement. You can send the signed copy tojj@rstudio.com.

  • Add thejournalname_article() function toR/article.R if the output format is simple enough, otherwise create a separateR/journalname_article.R.

  • Add the Pandoc LaTeX templateinst/rmarkdown/templates/journalname/resources/template.tex.

  • Add a skeleton articleinst/rmarkdown/templates/journalname/skeleton/skeleton.Rmd.

  • Add a description of the templateinst/rmarkdown/templates/journalname/template.yaml.

  • Please include the document class file (*.cls) if needed, but please do not include standard LaTeX packages (*.sty) that can be downloaded from CTAN. If you are using TinyTeX or TeX Live, you can verify if a package is available on CTAN viatinytex::parse_packages(files = "FILENAME"") (e.g., whenFILENAME isplain.bst, it should return"bibtex", which means this file is from a standard CTAN package). Please keep the number of new files absolutely minimal (e.g., do not include PDF output files), and also make examples minimal (e.g., if you need a.bib example, try to only leave one or two bibliography entries in it, and don't include too many items in it without using all of them).

  • Update Rd and namespace (could be done bydevtools::document()).

  • Update NEWS.

  • Update README with a link to the newly supported journal. Please add your Github username and the full name of the journal (follow other examples in the list).

  • Add a test totests/testit/test-formats.R by adding a linetest_format("journalname"). We try to keep them in alphabetical order.

  • Add your name to the list of authorsAuthors@R in DESCRIPTION. You don't need to bump the package version in DESCRIPTION.

Lastly, please try your best to do only one thing per pull request (e.g., if you want to add two output formats, do them in two separate pull requests), and refrain from making cosmetic changes in the code base:https://yihui.name/en/2018/02/bite-sized-pull-requests/

Thank you!

cderv and IndrajeetPatil reacted with thumbs up emoji
@CLAassistant
Copy link

CLAassistant commentedMay 4, 2021
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign ourContributor License Agreement before we can accept your contribution.
1 out of2 committers have signed the CLA.

✅ cderv
❌ gpilgrim2670
You have signed the CLA already but the status is still pending? Let usrecheck it.

@cderv
Copy link
Collaborator

@gpilgrim2670 do not forget to undraft this PR and ping me when this is ready for review.

Just checking in case you were already waiting for a review. Otherwise, take your time. Thanks

@gpilgrim2670
Copy link
Author

@cderv thanks for checking in. I'm actually waiting to hear back from the folks at JORS about some issues with their reference formatting style. Hopefully they'll get back to me soon, but I suspect it will be a while...

cderv reacted with thumbs up emoji

@cderv
Copy link
Collaborator

cderv commentedJun 9, 2021
edited
Loading

We are in no hurry. Thanks for the update !

@cderv
Copy link
Collaborator

Hi@gpilgrim2670,

I have just merge master branch in this PR to take into account the changes we've made recently. This will allow you to continue on good basis next time you work on this format.

Thanks.

@cderv
Copy link
Collaborator

👋@gpilgrim2670 - coming back here to get fresh information on the status of this work. Do you still plan to work on it ? Did you get feedback from JORS people ?

thank you

@cdervcderv added the WIP labelApr 19, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gpilgrim2670@CLAassistant@cderv

[8]ページ先頭

©2009-2025 Movatter.jp