- Notifications
You must be signed in to change notification settings - Fork1.3k
Feature: 1380 Sticky Header Update#1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CLAassistant commentedSep 17, 2022
|
Is this too risky to merge, or something,@cderv? I'm trying to decide whether I should wait for it or figure out how to pull in this code when building our books. |
I want to find time to test it and see the impact it has, especially on current users. As you have tested it, is this something that some users would want to opt-out ? My understanding was that it was for mobile only, but the current change seems to also modify the CSS for current style of non mobile view. I don't want to force changes of style to all existing bs4_book. Maybe we need some media query rule to use the CSS based on size of screen ?https://ui.dev/rwd/develop/browser-feature-support/media-queries-for-common-device-breakpoints |
Adds functionality for a sticky header for mobile