Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feature: 1380 Sticky Header Update#1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ax-jkriese wants to merge2 commits intorstudio:main
base:main
Choose a base branch
Loading
fromax-jkriese:feature/1380-header-update

Conversation

@ax-jkriese
Copy link

Adds functionality for a sticky header for mobile

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let usrecheck it.

@jtbayly
Copy link
Contributor

Is this too risky to merge, or something,@cderv?

I'm trying to decide whether I should wait for it or figure out how to pull in this code when building our books.

@cdervcderv linked an issueMay 5, 2023 that may beclosed by this pull request
@cderv
Copy link
Collaborator

I want to find time to test it and see the impact it has, especially on current users. As you have tested it, is this something that some users would want to opt-out ?

My understanding was that it was for mobile only, but the current change seems to also modify the CSS for current style of non mobile view. I don't want to force changes of style to all existing bs4_book.

Maybe we need some media query rule to use the CSS based on size of screen ?https://ui.dev/rwd/develop/browser-feature-support/media-queries-for-common-device-breakpoints

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cdervcdervAwaiting requested review from cderv

Assignees

@cdervcderv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FR] make the bs4_book sticky menu sticky on mobile

4 participants

@ax-jkriese@CLAassistant@jtbayly@cderv

[8]ページ先頭

©2009-2025 Movatter.jp