Thanks for your suggestion!

First let me start with some good practice for contribution:

• It would be great if next time you first open an issue for a new feature request so that we can discuss the interest of included it directly insidebookdown.
• Also, please create a branch and do a PR from your feature branch to master. This will allow to have cleaner Pull Request with only commits related to your feature. Currently, there are 26 commits but only the 8 last ones are relevant

About the PR:

Currently, this feature is adding a hard dependency (magick) and I am not sure we want one more hard dependency for an optional feature like this.

Also this is a pretty specific feature. Adding a background color to the head of the sidebar is quite easy with CSS already, and all other customization for style has to be done in CSS directly. This kind of precise customization (getting color from an image) does not feel in the scope ofbookdown directly but some helpers function to insert into your Rmd.
However, I understand the interest in easy customization of the style.

Did you already have example of some books out there which would use this feature ? I am trying to see how broad the usage would be for such feature.

Thanks.

Thanks for your suggestion!

First let me start with some good practice for contribution:

* It would be great if next time you first open an issue for a new feature request so that we can discuss the interest of included it directly inside **bookdown**.* Also, please create a branch and do a PR from your feature branch to master. This will allow to have cleaner Pull Request with only commits related to your feature. Currently, there are 26 commits but only the 8 last ones are relevant

About the PR:

Currently, this feature is adding a hard dependency (magick) and I am not sure we want one more hard dependency for an optional feature like this.

Also this is a pretty specific feature. Adding a background color to the head of the sidebar is quite easy with CSS already, and all other customization for style has to be done in CSS directly. This kind of precise customization (getting color from an image) does not feel in the scope ofbookdown directly but some helpers function to insert into your Rmd.
However, I understand the interest in easy customization of the style.

Did you already have example of some books out there which would use this feature ? I am trying to see how broad the usage would be for such feature.

Thanks.

Hi@cderv,

with respect to dependency, it can be removed only allowing the user of the package to pass a color, that is, removing the possibility of passing an image.

I also believe that, although it is easy to activate some features via CSS, many people in the field of statistics and who need a bookdown to produce their documents arrive, at most, close to _output.yml, not "getting their hands dirty" with CSS. I believe that if this resource were available, it would be used. It is a simple customization that does not change the general shape of the document. I don't have many examples of who uses it, just a biased example from the book I'm writing on computational statistics,https://prdm0.github.io/aulas_computacional/, in Portuguese 😆.

When I see other examples of customizations, these examples greatly modify the current form of the document and modify many elements, that is, they are made by people who "get their hands dirty" with CSS.

Anyway, I understand your positions and that's fine with me. 👍

Thanks.

First let me start with some good practice for contribution:

• It would be great if next time you first open an issue for a new feature request so that we can discuss the interest of included it directly insidebookdown.
• Also, please create a branch and do a PR from your feature branch to master. This will allow to have cleaner Pull Request with only commits related to your feature. Currently, there are 26 commits but only the 8 last ones are relevant

Thank you very much for the suggestions. It really makes the job of verifying the suggested changes a lot easier.

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign ourContributor License Agreement before we can accept your contribution.
1 out of2 committers have signed the CLA.

✅ cderv
❌ prdm0
_{You have signed the CLA already but the status is still pending? Let usrecheck it.}