Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitdebe936

Browse files
committed
test: connection.close's only callback parameter is error
1 parent6e83bd7 commitdebe936

File tree

1 file changed

+9
-31
lines changed

1 file changed

+9
-31
lines changed

‎test/nodeify.js‎

Lines changed: 9 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ describe('nodeify', () => {
4141
assert.ifError(err)
4242
assert.equal(result.$reql_type$,'TIME')
4343
})
44-
4544
awaitconnection.close()
4645
})
4746

@@ -72,31 +71,21 @@ describe('nodeify', () => {
7271
it('Testing conn.close with a callback - 1',asyncfunction(){
7372
awaitr.connect(config,function(err,conn){
7473
assert.ifError(err)
75-
conn.close(function(err,conn){
76-
assert.ifError(err)
77-
assert(!conn)
78-
})
74+
conn.close()
7975
})
8076
})
8177

8278
it('Testing conn.close with a callback - 2',asyncfunction(){
8379
awaitr.connect(config,function(err,conn){
8480
assert.ifError(err)
85-
conn.close({noreplyWait:true},function(err,conn){
86-
// This may or may not succeed, depending on the config file
87-
assert.ifError(err)
88-
assert(!conn)
89-
})
81+
conn.close({noreplyWait:true},assert.ifError)
9082
})
9183
})
9284

9385
it('Testing conn.noreplyWait with a callback',asyncfunction(){
9486
awaitr.connect(config,function(err,conn){
9587
assert.ifError(err)
96-
returnconn.noreplyWait(()=>{
97-
// This may or may not succeed, depending on the config file
98-
conn.close()
99-
})
88+
conn.noreplyWait(()=>conn.close())
10089
})
10190
})
10291
})
@@ -119,11 +108,8 @@ describe('nodeify', () => {
119108

120109
it('Testing valid syntax for `run` - 5',asyncfunction(){
121110
constresult=awaitr_.now().run(function(err,result){
122-
if(err){
123-
throwerr
124-
}else{
125-
returnresult
126-
}
111+
assert.ifError(err)
112+
returnresult
127113
})
128114
assert(resultinstanceofDate)
129115
})
@@ -151,31 +137,23 @@ describe('nodeify', () => {
151137
cursor.next(function(err,result){
152138
assert.ifError(err)
153139
assert.deepEqual(result,1)
154-
cursor.close().catch(assert.ifError)
155140
})
156141
})
157142
})
158143

159144
it('Testing cursor.close with a callback',asyncfunction(){
160145
awaitr_.expr([1,2,3]).run({cursor:true},function(err,cursor){
161146
assert.ifError(err)
162-
cursor.close(function(err,conn){
163-
assert.ifError(err)
164-
assert(!conn)
165-
})
147+
cursor.close()
166148
})
167149
})
168150

169151
it('Testing cursor.close with a callback when already closed',asyncfunction(){
170-
r_.expr([1,2,3]).run({cursor:true},function(err,cursor){
152+
awaitr_.expr([1,2,3]).run({cursor:true},function(err,cursor){
171153
assert.ifError(err)
172-
cursor.close(function(err,conn){
154+
cursor.close(function(err){
173155
assert.ifError(err)
174-
assert(!conn)
175-
cursor.close(function(err,conn){
176-
assert.ifError(err)
177-
assert(!conn)
178-
})
156+
cursor.close()
179157
})
180158
})
181159
})

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp