- Notifications
You must be signed in to change notification settings - Fork61
[Test] add @rescript/core to the tests.#741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Just to see how things look like.One comment is that the local file `Object.res` had to be renames as otherwise it would become unreachable.This is a side-effect of doing `-open RescriptCore` globally, which overrides the local scope. This won't be a problem when the library is integrated in the compiler.
| "label": "typeof", | ||
| "kind": 12, | ||
| "tags": [], | ||
| "detail": "'a => Core__Type.t", |
cristianocMar 7, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
NoticeCore__Type.t is leaked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
CC@zth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, I think we'll need to special case Core. Good catch.
Just to see how things look like.
One comment is that the local file
Object.reshad to be renames as otherwise it would become unreachable. This is a side-effect of doing-open RescriptCoreglobally, which overrides the local scope. This won't be a problem when the library is integrated in the compiler.