- Notifications
You must be signed in to change notification settings - Fork61
Find other binaries via compiler-info.json#1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| constprojectRewatchLockfiles=[ | ||
| ...Array.from(workspaceFolders).map((w)=> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ReScript lock was located at workspace level:lib/rescript.lock
Was absent onpackages/a/lib level, so it assumedbsb and failed.
| "..", | ||
| `@rescript/${target}/bin.js`, | ||
| ); | ||
| const{ binPaths}=awaitimport(targetPackagePath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The dynamic import ofrescript/../@rescript-platform package fails on pnpm because it is located deeply in thenode_module/.pnpm folder.node_modules/.pnpm/@rescript+darwin-arm64@12.0.0-beta.13/node_modules/@rescript/darwin-arm64/bin/
So, using the path fromcompiler-info.json is the better play.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great work! Changelog perhaps?
4bb6096 intorescript-lang:masterUh oh!
There was an error while loading.Please reload this page.
See sample inrescript-lang/end-to-end#1
Adds some fixes for#1106
package
ahas acompiler-info.jsonof:{"version":"12.0.0-beta.13","bsc_path":"/Users/nojaf/Projects/rescript-end-to-end/repos/pnpm/monorepo/node_modules/.pnpm/@rescript+darwin-arm64@12.0.0-beta.13/node_modules/@rescript/darwin-arm64/bin/bsc.exe","bsc_hash":"1263ce9a1dad7e30b855a8221d361b1147c2c1541a3f2600d09e954deb989ae6","rescript_config_hash":"68d9b6cfd83ac38869b2afe037b4fcbbbb9faa016302a2f26d45a1e7875e1479","runtime_path":"/Users/nojaf/Projects/rescript-end-to-end/repos/pnpm/monorepo/node_modules/.pnpm/@rescript+runtime@12.0.0-beta.13/node_modules/@rescript/runtime","generated_at":"1759387416473"}